Account - Invoicing

Merge lp://qastaging/~camptocamp/account-invoicing/account-analytic-required-vre into lp://qastaging/~account-core-editors/account-invoicing/7.0

  1. account-analytic-required-vre
  2. Merge into 7.0
Proposed by Vincent Renaville@camptocamp
Status: Needs review
Proposed branch: lp://qastaging/~camptocamp/account-invoicing/account-analytic-required-vre
Merge into: lp://qastaging/~account-core-editors/account-invoicing/7.0
Diff against target: 239 lines (+203/-0)
7 files modified
account_invoice_analytic_required/__init__.py (+23/-0)
account_invoice_analytic_required/__openerp__.py (+38/-0)
account_invoice_analytic_required/account_invoice_analytic_required.py (+31/-0)
account_invoice_analytic_required/i18n/account_invoice_analytic_required.pot (+27/-0)
account_invoice_analytic_required/i18n/es.po (+30/-0)
account_invoice_analytic_required/i18n/fr_BE.po (+27/-0)
account_invoice_analytic_required/i18n/sv.po (+27/-0)
To merge this branch: bzr merge lp://qastaging/~camptocamp/account-invoicing/account-analytic-required-vre
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza Needs Resubmitting
Lorenzo Battistini (community) Needs Fixing
Holger Brunn (Therp) code review Needs Fixing
Review via email: mp+218974@code.qastaging.launchpad.net

Description of the change

Hello,

The account_invoice_analytic_required force the user to specify an analytic account on invoice line

Vincent

To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

#60 sale.invoice.line?
#104 _description is not necessary here
#180ff you should remove translation files that don't actually contain translations

And per default, the field is only visible for analytic.group_analytic_accounting. I think this addon should remove this group from the view definition.

review: Needs Fixing (code review)
Reply
Revision history for this message
Lorenzo Battistini (elbati) wrote :

Thanks Vincent,

some style fixes:

account_invoice_analytic_required/__init__.py:3:2: W291 trailing whitespace
account_invoice_analytic_required/__init__.py:19:75: W291 trailing whitespace
account_invoice_analytic_required/__init__.py:23:14: E271 multiple spaces after keyword
account_invoice_analytic_required/__openerp__.py:3:2: W291 trailing whitespace
account_invoice_analytic_required/__openerp__.py:19:75: W291 trailing whitespace
account_invoice_analytic_required/__openerp__.py:23:1: O603 Manifest "license" key is missing
account_invoice_analytic_required/__openerp__.py:24:11: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:25:14: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:26:15: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:28:13: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:29:14: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:30:14: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:32:11: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:33:11: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:34:11: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:35:18: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:36:19: E203 whitespace before ':'
account_invoice_analytic_required/__openerp__.py:37:18: E203 whitespace before ':'
account_invoice_analytic_required/account_invoice_analytic_required.py:23:1: O603 Manifest "license" key is missing
account_invoice_analytic_required/account_invoice_analytic_required.py:25:1: E302 expected 2 blank lines, found 1
account_invoice_analytic_required/account_invoice_analytic_required.py:27:13: E225 missing whitespace around operator

account_invoice_analytic_required/__openerp__.py:24:80: E501 line too long (84 > 79 characters)
account_invoice_analytic_required/__openerp__.py:27:80: E501 line too long (94 > 79 characters)
account_invoice_analytic_required/account_invoice_analytic_required.py:30:80: E501 line too long (110 > 79 characters)

review: Needs Fixing
Reply
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

This project is now hosted on https://github.com/OCA/account-invoicing. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting
Reply

Unmerged revisions

47. By Vincent Renaville@camptocamp

[ADD] account_invoice_analytic_required : this modules force the user to specificed a analytic account on invoice line

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches