Merge lp://qastaging/~camptocamp/e-commerce-addons/7.0-receivable_account_payment_method-rde into lp://qastaging/~extra-addons-commiter/e-commerce-addons/7.0

Proposed by Romain Deheele - Camptocamp
Status: Needs review
Proposed branch: lp://qastaging/~camptocamp/e-commerce-addons/7.0-receivable_account_payment_method-rde
Merge into: lp://qastaging/~extra-addons-commiter/e-commerce-addons/7.0
Diff against target: 484 lines (+431/-0)
10 files modified
receivable_account_payment_method/__init__.py (+22/-0)
receivable_account_payment_method/__openerp__.py (+48/-0)
receivable_account_payment_method/account_invoice.py (+75/-0)
receivable_account_payment_method/account_invoice_view.xml (+39/-0)
receivable_account_payment_method/i18n/fr.po (+48/-0)
receivable_account_payment_method/i18n/receivable_account_payment_method.pot (+48/-0)
receivable_account_payment_method/payment_method.py (+32/-0)
receivable_account_payment_method/payment_method_view.xml (+26/-0)
receivable_account_payment_method/sale.py (+50/-0)
receivable_account_payment_method/test/receivable_account_payment_method.yml (+43/-0)
To merge this branch: bzr merge lp://qastaging/~camptocamp/e-commerce-addons/7.0-receivable_account_payment_method-rde
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Needs Resubmitting
Joël Grand-Guillaume @ camptocamp code review, no tests Needs Fixing
Review via email: mp+223738@code.qastaging.launchpad.net

Description of the change

Hello,

Here is a new addon to define a default receivable account on a payment method.
Goal : when an invoice is generated with this payment method, account_id on customer invoice
is populated according to this default receivable account.
Infos:
 - new field payment_method_id on invoice (sale payment method is propagated on invoice at confirmation)
 - partner and payment method changes are managed : if there is no payment method on invoice or no default receivable account on selected payment method, default receivable account set on partner is chosen.

Regards,

Romain

To post a comment you must log in.
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi,

Thanks a lot for this module ! We even have some tests, great !

Little things to change:

 * L136: No context=context for the .browse

Then, I would really find useful to add a group_by payment_method in the invoices search view. This way, in a few click, you know for example the amount by payment_method on open invoices and can compare with your "non-imported" bank statement.

Otherwise, perfect !

Joël

review: Needs Fixing (code review, no tests)
297. By Romain Deheele - Camptocamp

[UPD] test was deceptively green, need to create a manual invoice from the sale order

298. By Romain Deheele - Camptocamp

[UPD] add context on browse

299. By Romain Deheele - Camptocamp

[UPD] change test description

300. By Romain Deheele - Camptocamp

[UPD] Title underline too short in manifest

301. By Romain Deheele - Camptocamp

[ADD] Add filter by payment method on customer invoices

302. By Romain Deheele - Camptocamp

[UPD] display payment method on customer refund too

Revision history for this message
Romain Deheele - Camptocamp (romaindeheele) wrote :

Thanks Joel,

I add your suggestions.
I fix too another various things:
- fix the test
- display payment on customer refund too

Regards,

Romain

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

This project is now hosted on https://github.com/OCA/e-commerce. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Unmerged revisions

302. By Romain Deheele - Camptocamp

[UPD] display payment method on customer refund too

301. By Romain Deheele - Camptocamp

[ADD] Add filter by payment method on customer invoices

300. By Romain Deheele - Camptocamp

[UPD] Title underline too short in manifest

299. By Romain Deheele - Camptocamp

[UPD] change test description

298. By Romain Deheele - Camptocamp

[UPD] add context on browse

297. By Romain Deheele - Camptocamp

[UPD] test was deceptively green, need to create a manual invoice from the sale order

296. By Romain Deheele - Camptocamp

[ADD] add receivable_account_payment_method addon : allows to define a default receivable account according to a payment method

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches