Merge lp://qastaging/~camptocamp/openerp-humanitarian-ngo/addons-backport-improve_on_change-nbi into lp://qastaging/openerp-humanitarian-ngo/addons-backport
Proposed by
Nicolas Bessi - Camptocamp
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Yannick Vaucher @ Camptocamp | ||||
| Approved revision: | 30 | ||||
| Merged at revision: | 28 | ||||
| Proposed branch: | lp://qastaging/~camptocamp/openerp-humanitarian-ngo/addons-backport-improve_on_change-nbi | ||||
| Merge into: | lp://qastaging/openerp-humanitarian-ngo/addons-backport | ||||
| Diff against target: |
139 lines (+23/-21) 3 files modified
purchase/purchase.py (+8/-10) purchase/purchase_view.xml (+5/-5) purchase_requisition/purchase_requisition.py (+10/-6) |
||||
| To merge this branch: | bzr merge lp://qastaging/~camptocamp/openerp-humanitarian-ngo/addons-backport-improve_on_change-nbi | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Yannick Vaucher @ Camptocamp | code review, no tests | Approve | |
| Joël Grand-Guillaume @ camptocamp | code review, no tests | Approve | |
|
Review via email:
|
|||
Description of the change
Fix onchange_product_id on purchase order line that has a changed signature.
On change modification was not propagated on every addons and will
breaks community addons compatibility.
State validation has also be extracted and put in purchase extented.
This will allows to have standard PO to work too.
It will also help to get rid of this specific addons branch if possible at middle term
fix bug 1250507
MP https:/
To post a comment you must log in.
Revision history for this message
| Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote | # |
review:
Approve
(code review, no tests)
Revision history for this message
| Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote | # |
review:
Approve
(code review, no tests)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM, thanks !