Merge lp://qastaging/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_1250507-nbi into lp://qastaging/openerp-humanitarian-ngo/purchase-wkfl
Proposed by
Nicolas Bessi - Camptocamp
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 72 | ||||
| Proposed branch: | lp://qastaging/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_1250507-nbi | ||||
| Merge into: | lp://qastaging/openerp-humanitarian-ngo/purchase-wkfl | ||||
| Diff against target: |
55 lines (+23/-3) 2 files modified
purchase_extended/model/purchase_order.py (+3/-3) purchase_extended/view/purchase_order.xml (+20/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_1250507-nbi | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Joël Grand-Guillaume @ camptocamp | code review + test | Approve | |
| Romain Deheele - Camptocamp (community) | code review and test | Approve | |
|
Review via email:
|
|||
Description of the change
Fix the onchange_product_id that did not take in account the type of the PO. It breaks the possibility to make a standard requisition.
The code in pruchase extended is was a duplicate of modified purchase addon. Duplicate has bee remove from original addons backport.
We also try to find the less nasty 'non viable' solution to handle onchange, by putting required new args after context.
It should preserve other addons that override the same onchange but does not depends on purchase-extended.
Fix bug 1250507
To post a comment you must log in.
Revision history for this message
| Romain Deheele - Camptocamp (romaindeheele) wrote | # |
review:
Approve
(code review and test)
Revision history for this message
| Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote | # |
review:
Approve
(code review + test)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi,
LGTM,
Romain