Merge lp://qastaging/~camptocamp/openobject-addons/7.0-bugfix-1189480-with-perf-mdh into lp://qastaging/openobject-addons/7.0
Proposed by
Matthieu Dietrich @ camptocamp
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~camptocamp/openobject-addons/7.0-bugfix-1189480-with-perf-mdh |
| Merge into: | lp://qastaging/openobject-addons/7.0 |
| Diff against target: |
330 lines (+243/-20) 3 files modified
project/__openerp__.py (+1/-0) project/project.py (+68/-20) project/test/hours_process.yml (+174/-0) |
| To merge this branch: | bzr merge lp://qastaging/~camptocamp/openobject-addons/7.0-bugfix-1189480-with-perf-mdh |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Matthieu Dietrich @ camptocamp (community) | Needs Resubmitting | ||
| OpenERP Core Team | Pending | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2013-11-29.
Description of the change
The quick fix proposed in lp:~camptocamp/openobject-addons/7.0-fixes-bug-1189480 works, but the multiple read() severely impact performance. This solution uses a WITH RECURSIVE SQL statement in order to 1) avoid any extraneous read() 2) get all the information in one request.
I also added a YAML test to test both this new method and a hierarchical computation, since all YAML tests in addons are for a single level of projects.
To post a comment you must log in.
Revision history for this message
| Matthieu Dietrich @ camptocamp (mdietrich-c2c) wrote | # |
review:
Needs Resubmitting
Unmerged revisions
- 9665. By Matthieu Dietrich @ camptocamp
-
[FIX] PEP8-compliance + better check for float numbers
- 9664. By Matthieu Dietrich @ camptocamp
-
[IMP] performance improvement on progress rate calculation in projects
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Modified the code to be PEP-8 compliant + a better check for equality on float numbers.