Odoo Addons (MOVED TO GITHUB)

Merge lp://qastaging/~camptocamp/openobject-addons/extra-trunk-fix-1017960 into lp://qastaging/openobject-addons/extra-trunk

  1. extra-trunk-fix-1017960
  2. Merge into trunk-extra-addons
Proposed by Alexandre Fayolle - camptocamp
Status: Merged
Approved by: Guewen Baconnier @ Camptocamp
Approved revision: no longer in the source branch.
Merged at revision: 5771
Proposed branch: lp://qastaging/~camptocamp/openobject-addons/extra-trunk-fix-1017960
Merge into: lp://qastaging/openobject-addons/extra-trunk
Diff against target: 108 lines (+33/-10)
2 files modified
product_images_olbs/product.py (+24/-9)
product_images_olbs/product_images.py (+9/-1)
To merge this branch: bzr merge lp://qastaging/~camptocamp/openobject-addons/extra-trunk-fix-1017960
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Yannick Vaucher @ Camptocamp (community) Approve
Alexandre Fayolle - camptocamp Pending
Review via email: mp+114447@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Looks fine and clean to me

review: Approve
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Looks fine.
It'll work too when _image_path is overridden (to ignore the "default_code" in the path for instance), well thought patch.

Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches