Merge lp://qastaging/~camptocamp/project-service/7.0-port-project_service_type into lp://qastaging/~project-core-editors/project-service/trunk

To fix:
- "WARNING: The model project.service_type has no access rules, consider adding one."

Other comments:
- Project "Type": would it be adequate to call it "Budget type"? Personally I'm not familiar with "Forfait" and "Regie" terms. Probably I know them as "Fixed price" and "Responsibility / Closed price". It would be nice to add a little explanation on these on the field's Help text.

Ok for the comment. Do you agree with this king of comment ?

Fixed price -> 'when project price is an upfront agreed price'

Responsibility / Closed price -> 'when invoicing is based on actual worked time (only an hourly/daily price has been agreed).

I updated the terms and made help text:

Forfait (FR) -> Fixed price
Plafond (FR) -> Responsibility / Closed price
Régie (FR) -> Force account

Maybe not the best terms?

Sorry for not commenting earlier.

I've just learned that v7 official modules have some support for different type of service projects: take a look at https://doc.openerp.com/book/4/4_12_Services/4_12_Services_contract

If you install "Contract Management", you get new fields for the invoicing methods to use:
- `fix_price_invoices` flag, if there is fixed invoicing
- `invoice_on timesheets` flag, if there is invoicing based on actual work

Could this make the new `project_type` unnecessary?

> I updated the terms and made help text:
>
> Forfait (FR) -> Fixed price
> Plafond (FR) -> Responsibility / Closed price
> Régie (FR) -> Force account
>
> Maybe not the best terms?

Renaming the string of a selection is a thing. The 'stored' part of the selection should be renamed as well.

> If you install "Contract Management", you get new fields for the invoicing methods to use:
> - `fix_price_invoices` flag, if there is fixed invoicing
> - `invoice_on timesheets` flag, if there is invoicing based on actual work
>
> Could this make the new `project_type` unnecessary?

Good catch, this is something to consider.

Based on Daniel's comment, I would disapprove this MP as the need is already answered.

But I guess this module is a dependency of others and their migration requires an effort I don't know, which is why I will abstain.

That's a module we use at least for our own OpenERP.

My guess is that project_type exists for historical reasons, and we might consider to remove it if it can be replaced by native fields. I don't know exactly what it is used for and the implications if we change that.

Yannick, can you check, according to the Daniel's comment, if the 'project_type' is really a requirement for us and if it can be replaced by 'fix_price_invoices' and 'invoice_on timesheets'.

Thanks!