Project for Service Management

Merge lp://qastaging/~camptocamp/project-service/project_service_project_closing_vre into lp://qastaging/~project-core-editors/project-service/trunk

project_service_project_closing_vre
Merge into trunk

Proposed by Vincent Renaville@camptocamp on 2014-05-13

Status:	Needs review
Proposed branch:	lp://qastaging/~camptocamp/project-service/project_service_project_closing_vre
Merge into:	lp://qastaging/~project-core-editors/project-service/trunk
Diff against target:	108 lines (+93/-0) 3 files modified project_closing/__init__.py (+25/-0) project_closing/__openerp__.py (+36/-0) project_closing/project.py (+32/-0)
To merge this branch:	bzr merge lp://qastaging/~camptocamp/project-service/project_service_project_closing_vre
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Yannick Vaucher @ Camptocamp			Needs Fixing on 2014-05-16
Leonardo Pistone	code review	2014-05-13	Needs Fixing on 2014-05-13
Review via email: mp+219388@code.qastaging.launchpad.net

Description of the change

Hello,

The module project_closing, allow that an analytic account related to a project is automatically closed.
This feature is to prevent a person to enter time-sheet on a closed project.

Revision history for this message

Leonardo Pistone (lepistone) wrote on 2014-05-13:

Thanks Vincent.

- 2013 Camtpcaomp => 2014 Camptocamp
- version 1.1dr ?
- "category": "project Management",

- optional: you might find it clearer to do:

project.analytic_account_id.write({'state': 'open'})

calling the magic "write" method on the browse_record instance

review: Needs Fixing (code review)

Revision history for this message

Daniel Reis (dreis-pt) wrote on 2014-05-13:

Logic sound good for me.

Comments:
L56: could you add "summary" with a short description
L84,L98: you would be better off turning these comments into docstrings

Revision history for this message

Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote on 2014-05-16:

Agreed with Daniel docstring is the right path to follow.

review: Approve

Revision history for this message

Yannick Vaucher @ Camptocamp (yvaucher-c2c) on 2014-05-16:

review: Needs Fixing

lp://qastaging/~camptocamp/project-service/project_service_project_closing_vre updated on 2014-06-26

29. By Vincent Renaville@camptocamp on 2014-06-26: [FIX] add docstring + change write syntax + add module summary

Revision history for this message

Vincent Renaville@camptocamp (vrenaville-c2c) wrote on 2014-06-26:

Hello,

Thanks for the review and sorry for the delay.

I have just fix the modules according to your review.

Vincent

Revision history for this message

Daniel Reis (dreis-pt) wrote on 2014-07-01:

This project is now hosted on https://github.com/OCA/project-service. Please move your proposal there.
This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

Unmerged revisions

29. By Vincent Renaville@camptocamp on 2014-06-26: [FIX] add docstring + change write syntax + add module summary
28. By Vincent Renaville@camptocamp on 2014-05-13: [FIX] pep8
27. By Vincent Renaville@camptocamp on 2013-10-30: [ADD] project closing module