Stock and Logistic - Reports

Merge lp://qastaging/~camptocamp/stock-logistic-report/7.0-button-print-delivery-order into lp://qastaging/stock-logistic-report

  1. 7.0-button-print-delivery-order
  2. Merge into 7.0
Proposed by Guewen Baconnier @ Camptocamp
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 7
Merged at revision: 7
Proposed branch: lp://qastaging/~camptocamp/stock-logistic-report/7.0-button-print-delivery-order
Merge into: lp://qastaging/stock-logistic-report
Diff against target: 34 lines (+18/-1)
2 files modified
stock_picking_webkit/__openerp__.py (+3/-1)
stock_picking_webkit/stock_view.xml (+15/-0)
To merge this branch: bzr merge lp://qastaging/~camptocamp/stock-logistic-report/7.0-button-print-delivery-order
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Pedro Manuel Baeza Approve
Leonardo Pistone code review Approve
Review via email: mp+199952@code.qastaging.launchpad.net

Description of the change

The stock_picking_webkit aims to replace the RML report, but the button to print the delivery orders still print the RML report.

Change the action of the button to print the new one.

To post a comment you must log in.
Revision history for this message
Leonardo Pistone (lepistone) wrote :

LGTM, thanks

review: Approve (code review)
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Seems OK to me, but I wonder if it's not better to simply replace the report definition instead, because if there are other custom modules that use that report, they will still use the old report.

Regards.

review: Needs Information
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

> Seems OK to me, but I wonder if it's not better to simply replace the report
> definition instead, because if there are other custom modules that use that
> report, they will still use the old report.
>
> Regards.

This was done already in the module, but on the stock picking's report (stock.report_picking_list_out), and the button points to the delivery picking's report.
I fear the side effects on existing databases if we change that now.

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

OK then, Guewen.

Thank you.

Regards.

review: Approve
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) :
review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches