Stock And Logistic Warehouse

Merge lp://qastaging/~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe into lp://qastaging/stock-logistic-warehouse

7.0-improve_stock_location_ownership-afe
Merge into 7.0

Proposed by Alexandre Fayolle - camptocamp on 2014-03-13

Status:	Needs review
Proposed branch:	lp://qastaging/~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe
Merge into:	lp://qastaging/stock-logistic-warehouse
Diff against target:	126 lines (+100/-1) 4 files modified stock_location_ownership/__openerp__.py (+7/-1) stock_location_ownership/i18n/en.po (+31/-0) stock_location_ownership/i18n/fr.po (+31/-0) stock_location_ownership/i18n/stock_location_ownership.pot (+31/-0)
To merge this branch:	bzr merge lp://qastaging/~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Alexandre Fayolle - camptocamp			Needs Resubmitting on 2014-07-03
Ana Juaristi Olalde (community)			Approve on 2014-06-17
Sandy Carter (http://www.savoirfairelinux.com)	grammar		Needs Fixing on 2014-03-13
Pedro Manuel Baeza	code review		Approve on 2014-03-13
Yannick Vaucher @ Camptocamp		2014-03-13	Approve on 2014-03-13
Review via email: mp+210859@code.qastaging.launchpad.net

Description of the change

stock_location_ownership: add missing pot file, improve module description.

Revision history for this message

Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote on 2014-03-13:

Thanks LGTM

review: Approve

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-03-13:

Thank you very much for expand the description!

Regards.

review: Approve (code review)

Revision history for this message

Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote on 2014-03-13:

Grammar mistakes in the description

l.11 instances should be plural
This is useful for instance
This is useful for instances

l.12 comma after case
In which case a possible workflow
In which case, a possible workflow

l.12 run on sentence, consider breaking into two
In which case, a possible workflow
could be that the company is allowed to use that stock, but this would generate
a purchase order for the real owner of the stock, with or without direct
delivery.
In which case, a possible workflow
could be that the company is allowed to use that stock. This would generate
a purchase order for the real owner of the stock, with or without direct
delivery.

review: Needs Fixing (grammar)

Revision history for this message

Ana Juaristi Olalde (ajuaristio) wrote on 2014-06-17:

Thanks LGTM

review: Approve

Revision history for this message

Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote on 2014-07-03:

The source code management for this project has been moved to https://github.com/OCA/stock-logistics-warehouse

Could you resubmit this MP on the new site?

review: Needs Resubmitting

Unmerged revisions

36. By Alexandre Fayolle - camptocamp on 2014-03-13: [IMP] stock_location_ownership: improve addon description
35. By Alexandre Fayolle - camptocamp on 2014-03-13: [IMP] stock_location_ownership: add pot file and french translation