Merge lp://qastaging/~canonical-ca-hackers/ubuntu-webcatalog/962141-multiple-screenshots-for-all-apps into lp://qastaging/ubuntu-webcatalog
Proposed by
Łukasz Czyżykowski
| Status: | Merged |
|---|---|
| Approved by: | Danny Tamez |
| Approved revision: | 94 |
| Merged at revision: | 93 |
| Proposed branch: | lp://qastaging/~canonical-ca-hackers/ubuntu-webcatalog/962141-multiple-screenshots-for-all-apps |
| Merge into: | lp://qastaging/ubuntu-webcatalog |
| Diff against target: |
129 lines (+55/-5) 3 files modified
src/webcatalog/management/commands/import_app_install_data.py (+31/-5) src/webcatalog/schema.py (+2/-0) src/webcatalog/tests/test_commands.py (+22/-0) |
| To merge this branch: | bzr merge lp://qastaging/~canonical-ca-hackers/ubuntu-webcatalog/962141-multiple-screenshots-for-all-apps |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Danny Tamez (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Added multiple screenshots support for apps from the main archive.
Description of the change
Overview
========
This branch adds code to retrieve screenshot urls for apps which are in the main archive and because of that don't have access to extended media support from the devportal.
Details
=======
During the import of the apps from the apps-install-data, the screenshots.
The url for the screenshot server is a config variable.
To post a comment you must log in.
Revision history for this message
| Danny Tamez (zematynnad) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good Lukasz. The only thing I would change is instead of just eating the exception at line 48 to at least output it to the log so we have some idea if things go wrong.