Merge lp://qastaging/~canonical-dx-team/unity/unity.fix-646712 into lp://qastaging/unity
Proposed by
Mirco Müller
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 885 | ||||
| Proposed branch: | lp://qastaging/~canonical-dx-team/unity/unity.fix-646712 | ||||
| Merge into: | lp://qastaging/unity | ||||
| Diff against target: |
352 lines (+222/-2) 4 files modified
src/Launcher.cpp (+177/-1) src/Launcher.h (+20/-1) src/LauncherIcon.cpp (+22/-0) src/LauncherIcon.h (+3/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~canonical-dx-team/unity/unity.fix-646712 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Didier Roche-Tolomelli | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch makes the superkey-overlays show up on the launcher, if the Super-key is held down. The first 10 icons get labels and trash-can and workspace-switcher get special labels.
To post a comment you must log in.
Revision history for this message
| Mirco Müller (macslow) wrote | # |
Revision history for this message
| Mirco Müller (macslow) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
160 + if (_super_
(and following)… Can you please avoid by any mean to hardcode the keys?
The places can set dynamic values in their .place file for that for instance, so it won't scale. We will probably change the "t" and "w" shortcut as well. So having them in one place is better.
if you go over the model, I think you can get both the index and the shortcut.