Merge lp://qastaging/~canonical-isd-hackers/canonical-identity-provider/ssoclient into lp://qastaging/~ubuntuone-pqm-team/canonical-identity-provider/ssoclient

Proposed by Natalia Bidart
Status: Merged
Merged at revision: 15
Proposed branch: lp://qastaging/~canonical-isd-hackers/canonical-identity-provider/ssoclient
Merge into: lp://qastaging/~ubuntuone-pqm-team/canonical-identity-provider/ssoclient
Diff against target: 254 lines (+118/-26)
4 files modified
ssoclient/tests/test_v2.py (+71/-8)
ssoclient/v2/client.py (+31/-2)
ssoclient/v2/errors.py (+13/-16)
ssoclient/v2/http.py (+3/-0)
To merge this branch: bzr merge lp://qastaging/~canonical-isd-hackers/canonical-identity-provider/ssoclient
Reviewer Review Type Date Requested Status
Ricardo Kirkner (community) Approve
Review via email: mp+189166@code.qastaging.launchpad.net

Commit message

- Improving error management for validate_request.

To post a comment you must log in.
Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches