selenium-simple-test

Merge lp://qastaging/~canonical-isd-qa/selenium-simple-test/tables into lp://qastaging/selenium-simple-test

tables
Merge into trunk

Proposed by Michael Foord on 2012-01-16

Status:	Merged
Approved by:	Corey Goldberg on 2012-01-17
Approved revision:	257
Merged at revision:	250
Proposed branch:	lp://qastaging/~canonical-isd-qa/selenium-simple-test/tables
Merge into:	lp://qastaging/selenium-simple-test
Prerequisite:	lp://qastaging/~canonical-isd-qa/selenium-simple-test/goto-start
Diff against target:	290 lines (+198/-8) 8 files modified .bzrignore (+1/-0) src/sst/actions.py (+98/-3) src/sst/selftests/assert_element.py (+6/-3) src/sst/selftests/attribute.py (+11/-0) src/sst/selftests/tables.py (+40/-0) src/testproject/simple/views.py (+4/-1) src/testproject/templates/tables.html (+36/-0) src/testproject/urls.py (+2/-1)
To merge this branch:	bzr merge lp://qastaging/~canonical-isd-qa/selenium-simple-test/tables
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Corey Goldberg (community)		2012-01-16	Approve on 2012-01-17
Review via email: mp+88695@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-01-16.

Commit message

Add assert_attribute, assert_table_row_contains_text, assert_table_headers and assert_table_has_rows actions.

Description of the change

Add assert_attribute, assert_table_row_contains_text, assert_table_headers and assert_table_has_rows actions.

lp://qastaging/~canonical-isd-qa/selenium-simple-test/tables updated on 2012-01-16

252. By Michael Foord on 2012-01-16: Stub implementation of assert_table_row_contains
253. By Michael Foord on 2012-01-16: Implementation of assert_table_row_contains

Revision history for this message

Michael Foord (mfoord) wrote on 2012-01-16:

What do you think about these action names?

Currently the actions that act on table rows require the rows to be in a <tbody> so we don't have any ambiguity between header rows and normal rows. This is fine for our (current) internal requirements - maybe relax the restriction if we have complaints? (With the added complexity that relaxing the restriction brings.)

Revision history for this message

Michael Foord (mfoord) wrote on 2012-01-17:

I renamed assert_table_row_contains to assert_table_row_contains_text, because it is only asserting about text contents. I also added a regex parameter.

lp://qastaging/~canonical-isd-qa/selenium-simple-test/tables updated on 2012-01-17

254. By Michael Foord on 2012-01-17: Rename assert_table_row_contains to assert_table_row_contains_text and add regex parameter
255. By Michael Foord on 2012-01-17: Update action docstring
256. By Michael Foord on 2012-01-17: Adding assert_attribute action

Revision history for this message

Michael Foord (mfoord) wrote on 2012-01-17:

I needed to add assert_attribute to check that elements of a form are not disabled. If the disabled attribute is not set then assert_element('id', disabled='false') and variants *fail*. You have to fetch the element and then assert about the disabled attribute afterwards.

lp://qastaging/~canonical-isd-qa/selenium-simple-test/tables updated on 2012-01-17