address-book-app

Merge lp://qastaging/~canonical-platform-qa/address-book-app/add-photo-helper into lp://qastaging/address-book-app

  1. add-photo-helper
  2. Merge into trunk
Proposed by Richard Huddie
Status: Work in progress
Proposed branch: lp://qastaging/~canonical-platform-qa/address-book-app/add-photo-helper
Merge into: lp://qastaging/address-book-app
Diff against target: 206 lines (+94/-7)
6 files modified
debian/control (+1/-0)
src/imports/ContactEdit/ContactDetailAvatarEditor.qml (+1/-0)
tests/autopilot/address_book_app/pages/_contact_editor.py (+33/-4)
tests/autopilot/address_book_app/pages/_contact_list_page.py (+11/-0)
tests/autopilot/address_book_app/tests/__init__.py (+22/-0)
tests/autopilot/address_book_app/tests/test_edit_contact.py (+26/-3)
To merge this branch: bzr merge lp://qastaging/~canonical-platform-qa/address-book-app/add-photo-helper
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+227536@code.qastaging.launchpad.net

Description of the change

New helper method and test for adding a photo to a contact.

Requires content-hub-test-exporter from content-hub-testability to be installed: lp:~ken-vandine/content-hub/testability

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:229
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~canonical-platform-qa/address-book-app/add-photo-helper/+merge/227536/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/address-book-app-ci/620/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-amd64-ci/73
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-armhf-ci/73
        deb: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-armhf-ci/73/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-i386-ci/73
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2229/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1855/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2438/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3411
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3411/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10131
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1560/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2074
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2074/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/620/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://qastaging/~canonical-platform-qa/address-book-app/add-photo-helper updated
230. By Richard Huddie

merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:229
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~canonical-platform-qa/address-book-app/add-photo-helper/+merge/227536/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/address-book-app-ci/650/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-amd64-ci/103
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-armhf-ci/103
        deb: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-armhf-ci/103/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-i386-ci/103
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2645/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2115/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2771/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3888
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3888/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10605
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1768/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2372
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2372/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/650/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:230
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~canonical-platform-qa/address-book-app/add-photo-helper/+merge/227536/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/address-book-app-ci/651/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-amd64-ci/104
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-armhf-ci/104
        deb: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-armhf-ci/104/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-i386-ci/104
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2653/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2123/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2779/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3896
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3896/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10618
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1773/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2380
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2380/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/651/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:230
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~canonical-platform-qa/address-book-app/add-photo-helper/+merge/227536/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/address-book-app-ci/655/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-amd64-ci/108
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-armhf-ci/108
        deb: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-armhf-ci/108/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-utopic-i386-ci/108
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2963/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2351/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3021/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4206
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4206/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10915
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1946/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2617
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2617/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/655/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://qastaging/~canonical-platform-qa/address-book-app/add-photo-helper updated
231. By Richard Huddie

merge trunk

232. By Richard Huddie

merge from trunk

Unmerged revisions

232. By Richard Huddie

merge from trunk

231. By Richard Huddie

merge trunk

230. By Richard Huddie

merge trunk

229. By Richard Huddie

fix flake8

228. By Richard Huddie

test now working

227. By Richard Huddie

add content-hub-testability dependency

226. By Richard Huddie

add expected path validation

225. By Richard Huddie

move url conversion to contact editor

224. By Richard Huddie

merge trunk

223. By Richard Huddie

test updates and add def get_contact_avatar_file_path(self):

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches