Merge lp://qastaging/~canonical-platform-qa/autopilot-qt/wily_fix-unittests into lp://qastaging/autopilot-qt

Proposed by Christopher Lee
Status: Merged
Approved by: Brendan Donegan
Approved revision: 94
Merged at revision: 93
Proposed branch: lp://qastaging/~canonical-platform-qa/autopilot-qt/wily_fix-unittests
Merge into: lp://qastaging/autopilot-qt
Prerequisite: lp://qastaging/~laney/autopilot-qt/no-hardcode-xpathselect
Diff against target: 30 lines (+6/-4)
1 file modified
tests/unittests/tst_introspection.cpp (+6/-4)
To merge this branch: bzr merge lp://qastaging/~canonical-platform-qa/autopilot-qt/wily_fix-unittests
Reviewer Review Type Date Requested Status
Brendan Donegan (community) Approve
Max Brustkern (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+268990@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-08-25.

Commit message

Update unittest to reflect 2 new objects that appear in the object tree.

Description of the change

Update test to reflect 2 new objects that appear in the object tree.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Max Brustkern (nuclearbob) wrote :

This seems reasonable to me. I'm still working on running tests.

review: Approve
Revision history for this message
Max Brustkern (nuclearbob) wrote :

With the silo 19 PPA installed, I see test failures on unity8 I didn't see on trunk. We can investigate further.

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

> With the silo 19 PPA installed, I see test failures on unity8 I didn't see on
> trunk. We can investigate further.

Max: it's weird. Since those branches (excluding unity7) contain only rebuilds and your and Laney's changes which shouldn't cause u8 failures.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Okay, I've done a lot of retesting, and I haven't been able to reproduce any unity8 test failures with the silo ppa now. I'm checking the ubuntuuitoolkit and webbrowser_app tests, but things are probably okay at this point.

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Ok it seems the build errors are due to the old version of xpathselect in the archive, the version in -proposed works. There are some lintian errors on the build but those are pre-existing

review: Approve
Revision history for this message
Max Brustkern (nuclearbob) wrote :

FWIW, I've also completed the browser testing and found no errors, and the uuit testing looks good so far.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches