camera-app

Merge lp://qastaging/~canonical-platform-qa/camera-app/fix1444170-flake8 into lp://qastaging/camera-app

  1. fix1444170-flake8
  2. Merge into trunk
Proposed by Leo Arias
Status: Merged
Approved by: Florian Boucault
Approved revision: 559
Merged at revision: 569
Proposed branch: lp://qastaging/~canonical-platform-qa/camera-app/fix1444170-flake8
Merge into: lp://qastaging/camera-app
Prerequisite: lp://qastaging/~canonical-platform-qa/camera-app/fix_base_class
Diff against target: 680 lines (+118/-85)
13 files modified
debian/control (+1/-0)
debian/rules (+4/-0)
tests/autopilot/camera_app/emulators/main_window.py (+5/-5)
tests/autopilot/camera_app/emulators/panel.py (+5/-3)
tests/autopilot/camera_app/tests/__init__.py (+2/-5)
tests/autopilot/camera_app/tests/test_capture.py (+35/-20)
tests/autopilot/camera_app/tests/test_diskspace.py (+22/-17)
tests/autopilot/camera_app/tests/test_flash.py (+12/-9)
tests/autopilot/camera_app/tests/test_focus.py (+3/-3)
tests/autopilot/camera_app/tests/test_gallery_view.py (+10/-6)
tests/autopilot/camera_app/tests/test_options.py (+6/-3)
tests/autopilot/camera_app/tests/test_photo_editor.py (+11/-12)
tests/autopilot/camera_app/tests/test_zoom.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~canonical-platform-qa/camera-app/fix1444170-flake8
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+257806@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-04-29.

Commit message

Fixed the static errors reported by flake8.
Added the check to the debian build tests.
Added python3-flake8 as a build dependency.

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

Initial cleanup to make the tests more readable and maintainable.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:557
http://jenkins.qa.ubuntu.com/job/camera-app-ci/419/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/115
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/115
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/115/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/115
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/211
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/838/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/861
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/543
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20033
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/669/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/1000
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/1000/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/419/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~canonical-platform-qa/camera-app/fix1444170-flake8 updated
558. By Leo Arias

Added the flake8 check to debian rules.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:558
http://jenkins.qa.ubuntu.com/job/camera-app-ci/421/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/117
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/117
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/117/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/117
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/213
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/843/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/863
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/545
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20044
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/674/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/1005
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/1005/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/421/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~canonical-platform-qa/camera-app/fix1444170-flake8 updated
559. By Leo Arias

Fixed error in trunk.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:559
http://jenkins.qa.ubuntu.com/job/camera-app-ci/424/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/120
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/120
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/120/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/120
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/225
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/876
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/567
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20522

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/424/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches