Merge lp://qastaging/~canonical-platform-qa/camera-app/lp1366825_fix_zoom into lp://qastaging/camera-app

Proposed by Omer Akram
Status: Merged
Approved by: Florian Boucault
Approved revision: 390
Merged at revision: 411
Proposed branch: lp://qastaging/~canonical-platform-qa/camera-app/lp1366825_fix_zoom
Merge into: lp://qastaging/camera-app
Diff against target: 30 lines (+3/-4)
2 files modified
tests/autopilot/camera_app/tests/test_capture.py (+1/-2)
tests/autopilot/camera_app/tests/test_zoom.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~canonical-platform-qa/camera-app/lp1366825_fix_zoom
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Florian Boucault (community) Approve
Review via email: mp+233725@code.qastaging.launchpad.net

Commit message

autopilot: fix camera zoom bar not showing in test due to small initial pinch

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Omer Akram (om26er) wrote :

There seems to be a bug in the icons model, the settingsProperty for torch icon is sometimes given to the location icon, so that results in the test clicking on the wrong icon, hence causing test failure. https://bugs.launchpad.net/bugs/1369573

Revision history for this message
Florian Boucault (fboucault) wrote :

Looks great now. Tests seem to pass. Testing a bit more before final approve.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches