Merge lp://qastaging/~canonical-platform-qa/gallery-app/clean_delete_autopilot_tests into lp://qastaging/~artmello/gallery-app/gallery-app-fix_autopilot_tests
| Status: | Merged |
|---|---|
| Approved by: | Arthur Mello |
| Approved revision: | 1193 |
| Merged at revision: | 1192 |
| Proposed branch: | lp://qastaging/~canonical-platform-qa/gallery-app/clean_delete_autopilot_tests |
| Merge into: | lp://qastaging/~artmello/gallery-app/gallery-app-fix_autopilot_tests |
| Diff against target: |
195 lines (+69/-49) 2 files modified
tests/autopilot/gallery_app/emulators/photo_viewer.py (+44/-16) tests/autopilot/gallery_app/tests/test_photo_viewer.py (+25/-33) |
| To merge this branch: | bzr merge lp://qastaging/~canonical-platform-qa/gallery-app/clean_delete_autopilot_tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Arthur Mello | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2015-04-16.
Commit message
Added an autopilot test to check the deletion of a photo.
Description of the change
Please note a couple of things from this branch:
1. The helpers are split into classes that represent the parts of the screen that we are interacting with: all the helpers related to the PopupPhotoViewer are written in the respective class.
2. The public methods of the classes are named after actions that a user does: delete_
3. The public methods are annotated so they leave a log trace when they are called. In case of error, you can read the log and see what the test was excecutiong when an error was found.
4. A test does a single action and has a single check at the end:
delete a photo and check that it no longer exists in the filesystem.
I left an XXX comment on the old delete test because it has to be split in smaller tests. And as those smaller tests are not representing a user goal, they should be written in QML. Arthur said he was going to start writing those tests, when he is done the old delete autopilot test can be removed.
| Arthur Mello (artmello) | # |
