gallery-app

Merge lp://qastaging/~canonical-platform-qa/gallery-app/fix1376423-no_backup into lp://qastaging/~canonical-platform-qa/gallery-app/clean_autopilot_setup

fix1376423-no_backup
Merge into clean_autopilot_setup

Proposed by Leo Arias on 2014-10-15

Status:

Needs review

Proposed branch:

lp://qastaging/~canonical-platform-qa/gallery-app/fix1376423-no_backup

Merge into:

lp://qastaging/~canonical-platform-qa/gallery-app/clean_autopilot_setup

Prerequisite:

lp://qastaging/~canonical-platform-qa/gallery-app/fix1381259-launch_fixture

Diff against target:

108 lines (+21/-28)

1 file modified

tests/autopilot/gallery_app/tests/__init__.py (+21/-28)

To merge this branch:

bzr merge lp://qastaging/~canonical-platform-qa/gallery-app/fix1376423-no_backup

Undecided

In Progress

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration	2014-10-15	Pending
Ubuntu Phablet Team		2014-10-15	Pending
Review via email: mp+238383@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-10-14.

Commit message

Do not backup existing files during autopilot tests. We will assume a clean environment from now on.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-14: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1065/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Leo Arias (elopio) wrote on 2014-10-14: Posted in a previous version of this proposal

In order to remove the backups, we need to stop deleting the real folders.
In order to stop deleting the real folders, we need a better hierarchy of test cases and a fixture to launch the app.
I will start with the fixture.

lp://qastaging/~canonical-platform-qa/gallery-app/fix1376423-no_backup updated on 2014-10-20

1104. By Leo Arias on 2014-10-15: Fixed the method definition.
1105. By Leo Arias on 2014-10-15: Keep the database patching for now.
1106. By Leo Arias on 2014-10-20: Make the pictures dir location and configuration independent.
1107. By Leo Arias on 2014-10-20: Reverted to use the hardcoded path. The phone doesn't have xdg-user-dir.
1108. By Leo Arias on 2014-10-20: Raise an exception if the pictures directory is not empty.
1109. By Leo Arias on 2014-10-20: Clean the pictures directory.
1110. By Leo Arias on 2014-10-20: Clean the pictures directory.

Unmerged revisions

1110. By Leo Arias on 2014-10-20: Clean the pictures directory.
1109. By Leo Arias on 2014-10-20: Clean the pictures directory.
1108. By Leo Arias on 2014-10-20: Raise an exception if the pictures directory is not empty.
1107. By Leo Arias on 2014-10-20: Reverted to use the hardcoded path. The phone doesn't have xdg-user-dir.
1106. By Leo Arias on 2014-10-20: Make the pictures dir location and configuration independent.
1105. By Leo Arias on 2014-10-15: Keep the database patching for now.
1104. By Leo Arias on 2014-10-15: Fixed the method definition.
1103. By Leo Arias on 2014-10-15: Merged with prerequisite.
1102. By Leo Arias on 2014-10-14: Do not backup existing files during autopilot tests. We will assume a clean environment from now on.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Canonical Platform QA Team