Merge lp://qastaging/~canonical-platform-qa/gallery-app/qmltests1 into lp://qastaging/gallery-app

Proposed by Leo Arias
Status: Approved
Approved by: Arthur Mello
Approved revision: 1069
Proposed branch: lp://qastaging/~canonical-platform-qa/gallery-app/qmltests1
Merge into: lp://qastaging/gallery-app
Diff against target: 205 lines (+121/-1)
8 files modified
CMakeLists.txt (+1/-0)
debian/control (+4/-0)
debian/rules (+0/-1)
rc/CMakeLists.txt (+2/-0)
rc/qml/Components/EventCard.qml (+2/-0)
tests/CMakeLists.txt (+1/-0)
tests/qml/CMakeLists.txt (+36/-0)
tests/qml/Components/tst_EventCard.qml (+75/-0)
To merge this branch: bzr merge lp://qastaging/~canonical-platform-qa/gallery-app/qmltests1
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Arthur Mello (community) Approve
Chris Gagnon (community) Approve
Sebastien Bacher the debian directory Approve
Review via email: mp+235390@code.qastaging.launchpad.net

Commit message

Added the initial QML test suite.

Description of the change

Are there any related MPs required for this MP to build/function as expected? Please list.

No related MPs.

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

It is now.

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

No manual tests as I didn't change any functionality. But I ran the new suite many times in many different ways.

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?

No manual tests needed.

If you changed the UI, was the change specified/approved by design?

No UI changes.

If you changed UI labels, did you update the pot file?

No labels changes.

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

Yes, it was reviewed by seb.

To post a comment you must log in.
1063. By Leo Arias

Added deps.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1064. By Leo Arias

Override the dh_auto_test

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1065. By Leo Arias

Merged with trunk.

1066. By Leo Arias

Removed the auto_test oerride.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1067. By Leo Arias

Added the missing dependency.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1068. By Leo Arias

Removed the minimal platform.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

the packaging changes looks correct

review: Approve (the debian directory)
Revision history for this message
Sebastien Bacher (seb128) wrote :

(can you remove ubuntu-core-dev from the reviewer so it stops being in the Ubuntu sponsoring queue?)

Revision history for this message
Leo Arias (elopio) wrote :

Yes. Thanks Sebastien.

Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

The tests lgtm

review: Approve
Revision history for this message
Arthur Mello (artmello) wrote :

lgtm

review: Approve
1069. By Leo Arias

Merged with trunk.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1070. By Leo Arias

Merged with trunk.

Unmerged revisions

1070. By Leo Arias

Merged with trunk.

1069. By Leo Arias

Merged with trunk.

1068. By Leo Arias

Removed the minimal platform.

1067. By Leo Arias

Added the missing dependency.

1066. By Leo Arias

Removed the auto_test oerride.

1065. By Leo Arias

Merged with trunk.

1064. By Leo Arias

Override the dh_auto_test

1063. By Leo Arias

Added deps.

1062. By Leo Arias

Merged with trunk.

1061. By Leo Arias

Added the initial QML test suite.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches