qakit

Merge lp://qastaging/~canonical-platform-qa/qakit/flake8-fixes into lp://qastaging/qakit

  1. flake8-fixes
  2. Merge into trunk
Proposed by Allan LeSage
Status: Approved
Approved by: Allan LeSage
Approved revision: 6
Proposed branch: lp://qastaging/~canonical-platform-qa/qakit/flake8-fixes
Merge into: lp://qastaging/qakit
Diff against target: 428 lines (+65/-68)
11 files modified
qakit/__init__.py (+2/-2)
qakit/commands.py (+8/-7)
qakit/config.py (+2/-2)
qakit/format.py (+18/-12)
qakit/lkkb.py (+11/-9)
qakit/tests/__init__.py (+2/-3)
qakit/tests/test_config.py (+2/-4)
qakit/tests/test_format.py (+5/-6)
qakit/tests/test_trello.py (+3/-6)
qakit/trello.py (+7/-12)
setup.py (+5/-5)
To merge this branch: bzr merge lp://qastaging/~canonical-platform-qa/qakit/flake8-fixes
Reviewer Review Type Date Requested Status
Vincent Ladeuil Pending
Thomi Richards Pending
Leo Arias Pending
Review via email: mp+257664@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-04-17.

Description of the change

Flake8 fixes

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote : Posted in a previous version of this proposal

@Federico: Thanks for doing this !

Let's get those flake8 issues out of the way and automated asap.

I have a few questions/comments inline but nothing blocking this MP landing.

review: Approve
Revision history for this message
Brendan Donegan (brendan-donegan) : Posted in a previous version of this proposal
Revision history for this message
Federico Gimenez (fgimenez) wrote : Posted in a previous version of this proposal

Hi Vincent, about the license boilerplate this is text that we are using in other projects like ubuntu-sanity-tests, ubuntu-power-tests and ubuntu-ota-tests, for instance [1]. It comes from the FSF recommendation at [2], but seems that we are using the one-file program recommendation for multi-file programs, we should discuss adopting the right one.

Thanks,

[1] http://bazaar.launchpad.net/~canonical-platform-qa/ubuntu-sanity-tests/trunk/view/head:/ubuntu_sanity_tests/selftests/__init__.py
[2] https://www.gnu.org/licenses/gpl-howto.html

Revision history for this message
Allan LeSage (allanlesage) wrote :

I'll just top-approve this, previously approved.

Reply

Unmerged revisions

6. By Federico Gimenez

making flake8 happy

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: