Ubuntu Notes app

Merge lp://qastaging/~canonical-platform-qa/reminders-app/qmltest1 into lp://qastaging/reminders-app

  1. qmltest1
  2. Merge into trunk
Proposed by Leo Arias
Status: Rejected
Rejected by: Michael Zanetti
Proposed branch: lp://qastaging/~canonical-platform-qa/reminders-app/qmltest1
Merge into: lp://qastaging/reminders-app
Diff against target: 212 lines (+145/-5)
7 files modified
CMakeLists.txt (+3/-3)
debian/control (+6/-1)
src/plugin/CMakeLists.txt (+2/-0)
src/plugin/Evernote/CMakeLists.txt (+0/-1)
tests/CMakeLists.txt (+2/-0)
tests/qml/CMakeLists.txt (+36/-0)
tests/qml/tst_notebooksDelegate.qml (+96/-0)
To merge this branch: bzr merge lp://qastaging/~canonical-platform-qa/reminders-app/qmltest1
Reviewer Review Type Date Requested Status
David Planella Needs Information
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Review via email: mp+239466@code.qastaging.launchpad.net

Commit message

Added an initial QML test.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:289
http://91.189.93.70:8080/job/reminders-app-ci/563/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1226/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/259/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/563/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:291
http://91.189.93.70:8080/job/reminders-app-ci/566/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1249/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/262/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/566/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:292
http://91.189.93.70:8080/job/reminders-app-ci/568/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1254/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/264/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/568/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

There's something wrong on the build. Working on that...

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:293
http://91.189.93.70:8080/job/reminders-app-ci/572/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1361
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1361/artifact/work/output/*zip*/output.zip
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/268/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/572/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

Leo, would you mind adding to the description of the MP:
- What this test is supposed to be testing
- What the recommended way to add QML tests is, so that we can have some guidelines for future tests

Thanks!

review: Needs Information
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Leo, you might consider adding a README file which explains to new contributors on how to run these qml tests. You can use clock app's readme at https://bazaar.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/utopic-3.0/view/head:/README.unittest as reference if required.

Revision history for this message
Michael Zanetti (mzanetti) wrote :

one inline comment. looks good to me otherwise.

Revision history for this message
Leo Arias (elopio) wrote :

ACK. Back to work in progress. I'll try to assign some time for this next week. Thanks for the reviews.

Revision history for this message
Michael Zanetti (mzanetti) wrote :

Elopio, I took this and did some fixes and more tests on top of it. Mainly I wanted to set up an environment to test the full app in offline mode with qmltests. Seems to work quite nicely. If you have time, it'd be great to get a review.

https://code.launchpad.net/~mzanetti/reminders-app/qmltest2/+merge/253598

As the other branch contains this one, I'll remove this one from the queue.

Thanks

Revision history for this message
Leo Arias (elopio) wrote :

you rule.
I'll review it tomorrow. Thanks!

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches