selenium-simple-test

Merge lp://qastaging/~canonical-platform-qa/selenium-simple-test/fix1394741-remote_browser_init into lp://qastaging/selenium-simple-test

  1. fix1394741-remote_browser_init
  2. Merge into trunk
Proposed by Leo Arias
Status: Work in progress
Proposed branch: lp://qastaging/~canonical-platform-qa/selenium-simple-test/fix1394741-remote_browser_init
Merge into: lp://qastaging/selenium-simple-test
Prerequisite: lp://qastaging/~canonical-platform-qa/selenium-simple-test/fix1289990-update_sst-remote_count
Diff against target: 108 lines (+76/-1)
2 files modified
src/sst/tests/fake_selenium_server.py (+46/-0)
src/sst/tests/test_remote_script.py (+30/-1)
To merge this branch: bzr merge lp://qastaging/~canonical-platform-qa/selenium-simple-test/fix1394741-remote_browser_init
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Needs Fixing
Alexander Kamyanskiy (community) Needs Information
Review via email: mp+242428@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexander Kamyanskiy (kamyanskiy) wrote :

Hi Leo, Sorry, probably I'm wrong, but I'm not feel this test covers order of parameters when we construct webdriver class in src/sst/browser.py as:

"return self.webdriver_class(self.remote_url, self.capabilities)"

review: Needs Information
Reply
Revision history for this message
Vincent Ladeuil (vila) wrote :

> I'm not feel this test covers order of parameters

Yeah for failing test first ;)

Some comments inline, bottom line: no server in a thread please, there be dragons !

review: Needs Fixing
Reply

Unmerged revisions

441. By Leo Arias

Added a test that exposes bug 1394741.

440. By Leo Arias

Added a test that exposes bug 1289990.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches