ubuntu-keyboard

Merge lp://qastaging/~canonical-platform-qa/ubuntu-keyboard/fix1444170-flake8 into lp://qastaging/ubuntu-keyboard

  1. fix1444170-flake8
  2. Merge into trunk
Proposed by Leo Arias
Status: Merged
Approved by: Bill Filler
Approved revision: 361
Merged at revision: 366
Proposed branch: lp://qastaging/~canonical-platform-qa/ubuntu-keyboard/fix1444170-flake8
Merge into: lp://qastaging/ubuntu-keyboard
Prerequisite: lp://qastaging/~canonical-platform-qa/ubuntu-keyboard/fix_base_class
Diff against target: 405 lines (+75/-46)
6 files modified
debian/control (+1/-0)
debian/rules (+1/-0)
tests/autopilot/ubuntu_keyboard/emulators/keyboard.py (+13/-8)
tests/autopilot/ubuntu_keyboard/emulators/keypad.py (+10/-2)
tests/autopilot/ubuntu_keyboard/tests/test_keyboard.py (+47/-35)
tools/overrides-from-hunspell.py (+3/-1)
To merge this branch: bzr merge lp://qastaging/~canonical-platform-qa/ubuntu-keyboard/fix1444170-flake8
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Michael Sheldon (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+257815@code.qastaging.launchpad.net

Commit message

Fixed the static errors reported by flake8.
Added the check to the debian build tests.
Added python3-flake8 as a build dependency.

Description of the change

Initial cleanup to make the tests more readable and maintainable.

Are there any related MPs required for this MP to build/function as expected? Please list.

Yes, the fix base class is a prerequisite to avoid potential conflicts.

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

Yes.

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?

Only changes to the tests, so no need to run the manual test plan.

If you changed the UI, was the change specified/approved by design?

No UI changes.

If you changed UI labels, did you update the pot file?

No UI changes.

If you changed the packaging (debian), did you add a core-dev as a reviewer to
this MP?

Adding the core dev team...

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:361
http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-ci/590/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2539
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-vivid-amd64-ci/91
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-vivid-armhf-ci/91
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-vivid-armhf-ci/91/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-keyboard-vivid-i386-ci/91
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2200
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2537
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2537/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20046

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-keyboard-ci/590/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?

 * Yes (just ran tests locally, as there were no changes to main app code)

Did CI run pass? If not, please explain why.

 * Unrelated flaky test

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?

 * Yes

review: Approve
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Packaging change looks fine

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches