Merge lp://qastaging/~canonical-platform-qa/ubuntu-power-tests/preserve-powerd-cli into lp://qastaging/ubuntu-power-tests

Proposed by Federico Gimenez
Status: Needs review
Proposed branch: lp://qastaging/~canonical-platform-qa/ubuntu-power-tests/preserve-powerd-cli
Merge into: lp://qastaging/ubuntu-power-tests
Prerequisite: lp://qastaging/~canonical-platform-qa/ubuntu-power-tests/initial-commit-of-existing
Diff against target: 39 lines (+4/-2)
3 files modified
.bzrignore (+0/-1)
README (+2/-0)
power-meter-tests/test_upload.sh (+2/-1)
To merge this branch: bzr merge lp://qastaging/~canonical-platform-qa/ubuntu-power-tests/preserve-powerd-cli
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Federico Gimenez (community) Approve
Max Brustkern (community) Approve
Christopher Lee (community) Needs Fixing
Review via email: mp+255252@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-04-06.

Commit message

Added adb script for not closing powerd-cli on cleanup

Description of the change

Added adb script for not closing powerd-cli on cleanup. The test_upload.sh accepts as a third parameter the adb script to use, if not specified defaults to adb.

To post a comment you must log in.
Revision history for this message
Christopher Lee (veebers) wrote :

Have we made communications or filed a bug so that we may get this fixed in trunk for autopkgtest? I would rather not carry another forked adb script that doesn't keep up to date.

I think it's ok to use it in the interim, as long as we have a bug and intentions to have it fixed upstream. (the hard part is keeping pressure on this and actually following it up and getting it updated.

One inline comment

review: Needs Fixing
Revision history for this message
Federico Gimenez (fgimenez) wrote :

Thanks Chris, I've already asked Martin about this and filed a bug [1], also mentioned in the forked file.

[1] https://bugs.launchpad.net/ubuntu/+source/autopkgtest/+bug/1441023

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Comment inline about not losing task to keep test metadata for which tests should have screen on. Other than that, LGTM.

review: Approve
Revision history for this message
Federico Gimenez (fgimenez) wrote :

Ok, I've reverted the README TODO comment to keep an eye on how to designate which test should keep the screen on, right now the only thing that comes to my mind is identifying the tests by name and that seems to be a bit brittle.

Cheers!

Revision history for this message
Max Brustkern (nuclearbob) wrote :

> Ok, I've reverted the README TODO comment to keep an eye on how to designate
> which test should keep the screen on, right now the only thing that comes to
> my mind is identifying the tests by name and that seems to be a bit brittle.

Yeah, I want a better solution than that, but I don't have one yet. We can discuss it with the team.

>
> Cheers!

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~canonical-platform-qa/ubuntu-power-tests/preserve-powerd-cli/+merge/255252/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:9
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~canonical-platform-qa/ubuntu-power-tests/preserve-powerd-cli/+merge/255252/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/ubuntu-power-tests-ci/2/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-power-tests-vivid-amd64-ci/2/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-power-tests-vivid-armhf-ci/2/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-power-tests-vivid-i386-ci/2/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-power-tests-ci/2/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Federico Gimenez (fgimenez) :
review: Needs Resubmitting
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
10. By Federico Gimenez

merged trunk

Revision history for this message
Federico Gimenez (fgimenez) :
review: Needs Resubmitting
Revision history for this message
Martin Pitt (pitti) wrote :

For the record, bug 1441023 is fixed in git now. CI has a LP recipe to build packages from autopkgtest git and use that in production; if you need that in vivid proper, please let me know.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Federico Gimenez (fgimenez) wrote :

> For the record, bug 1441023 is fixed in git now. CI has a LP recipe to build
> packages from autopkgtest git and use that in production; if you need that in
> vivid proper, please let me know.

Thanks a lot pitti for this immediate fix! :) The fork works for this sprint but we should allocate time to remove it as soon as possible.

review: Approve
11. By Federico Gimenez

Using adt-run --keep-screen-active option

Revision history for this message
Federico Gimenez (fgimenez) wrote :

Updated to use the --keep-screen-active option

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Max Brustkern (nuclearbob) wrote :

We're handling this a different way now. I think we should document the DISPLAYON variable, among others, in a separate proposal. I filed a bug for that here:
https://bugs.launchpad.net/ubuntu-power-tests/+bug/1455096
We can get it made into a card at some point.

Unmerged revisions

11. By Federico Gimenez

Using adt-run --keep-screen-active option

10. By Federico Gimenez

merged trunk

9. By Federico Gimenez

merged trunk

8. By Federico Gimenez

Reverted TODO comment for designating tests to preserve powerd-cli

7. By Federico Gimenez

Fixed typo

6. By Federico Gimenez

Added comment about forked script

5. By Federico Gimenez

readded .bzrignore

4. By Federico Gimenez

removed .bzrignore

3. By Federico Gimenez

adb script to preserve powerd-cli; updated README

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: