Merge lp://qastaging/~canonical-platform-qa/ubuntu-power-tests/preserve-powerd-cli into lp://qastaging/ubuntu-power-tests
Proposed by
Federico Gimenez
Status: | Needs review |
---|---|
Proposed branch: | lp://qastaging/~canonical-platform-qa/ubuntu-power-tests/preserve-powerd-cli |
Merge into: | lp://qastaging/ubuntu-power-tests |
Prerequisite: | lp://qastaging/~canonical-platform-qa/ubuntu-power-tests/initial-commit-of-existing |
Diff against target: |
39 lines (+4/-2) 3 files modified
.bzrignore (+0/-1) README (+2/-0) power-meter-tests/test_upload.sh (+2/-1) |
To merge this branch: | bzr merge lp://qastaging/~canonical-platform-qa/ubuntu-power-tests/preserve-powerd-cli |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Approve | |
Federico Gimenez (community) | Approve | ||
Max Brustkern (community) | Approve | ||
Christopher Lee (community) | Needs Fixing | ||
Review via email:
|
This proposal supersedes a proposal from 2015-04-06.
Commit message
Added adb script for not closing powerd-cli on cleanup
Description of the change
Added adb script for not closing powerd-cli on cleanup. The test_upload.sh accepts as a third parameter the adb script to use, if not specified defaults to adb.
To post a comment you must log in.
Unmerged revisions
- 11. By Federico Gimenez
-
Using adt-run --keep-
screen- active option - 10. By Federico Gimenez
-
merged trunk
- 9. By Federico Gimenez
-
merged trunk
- 8. By Federico Gimenez
-
Reverted TODO comment for designating tests to preserve powerd-cli
- 7. By Federico Gimenez
-
Fixed typo
- 6. By Federico Gimenez
-
Added comment about forked script
- 5. By Federico Gimenez
-
readded .bzrignore
- 4. By Federico Gimenez
-
removed .bzrignore
- 3. By Federico Gimenez
-
adb script to preserve powerd-cli; updated README
Have we made communications or filed a bug so that we may get this fixed in trunk for autopkgtest? I would rather not carry another forked adb script that doesn't keep up to date.
I think it's ok to use it in the interim, as long as we have a bug and intentions to have it fixed upstream. (the hard part is keeping pressure on this and actually following it up and getting it updated.
One inline comment