Merge lp://qastaging/~canonical-platform-qa/ubuntu-test-cases/memevent-update-nfss into lp://qastaging/ubuntu-test-cases/touch

Proposed by Christopher Lee
Status: Rejected
Rejected by: Max Brustkern
Proposed branch: lp://qastaging/~canonical-platform-qa/ubuntu-test-cases/memevent-update-nfss
Merge into: lp://qastaging/ubuntu-test-cases/touch
Diff against target: 676 lines (+335/-249)
10 files modified
tests/memevent/nfss_upload_results.py (+177/-0)
tests/memevent/tslist.auto (+2/-2)
tests/memevent/ubuntu_test_cases/memory_usage_measurement/apps/browser.py (+0/-103)
tests/memevent/ubuntu_test_cases/memory_usage_measurement/apps/camera.py (+0/-58)
tests/memevent/ubuntu_test_cases/memory_usage_measurement/probes.py (+21/-7)
tests/memevent/ubuntu_test_cases/memory_usage_measurement/tests/__init__.py (+69/-0)
tests/memevent/ubuntu_test_cases/memory_usage_measurement/tests/test_browser.py (+30/-0)
tests/memevent/ubuntu_test_cases/memory_usage_measurement/tests/test_camera.py (+20/-0)
tests/memevent/ubuntu_test_cases/memory_usage_measurement/tests/test_gallery.py (+16/-0)
tests/memevent/ubuntu_test_cases/memory_usage_measurement/tests/test_memory_usage.py (+0/-79)
To merge this branch: bzr merge lp://qastaging/~canonical-platform-qa/ubuntu-test-cases/memevent-update-nfss
Reviewer Review Type Date Requested Status
Paul Larson Needs Fixing
Review via email: mp+231467@code.qastaging.launchpad.net

Commit message

Updated memevent tests so they're not duplicating test code. Added upload script that puts data into NFSS backend.

Description of the change

Updated memevent tests so they're not duplicating test code. Added upload script that puts data into NFSS backend.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

Great! Small comment below. Also, I think there are some changes to the jenkins job needed to set a location to push the results to right? The nfss server, port, any auth information? I don't see anything here that actually calls nfss_upload_results. That should probably be part of the scripts that run under utah I guess, consuming the config data established in the job itself. I'm not sure where the best place to do that is, but this is all new stuff, so I'm sure all future ones will follow your example. :)

review: Needs Fixing
275. By Max Brustkern

Merged changes

276. By Max Brustkern

Merged changes

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches