Ubuntu Test Cases

Merge lp://qastaging/~canonical-platform-qa/ubuntu-test-cases/sample-adt-test into lp://qastaging/ubuntu-test-cases/touch

  1. sample-adt-test
  2. Merge into touch
Proposed by Leo Arias
Status: Merged
Merged at revision: 352
Proposed branch: lp://qastaging/~canonical-platform-qa/ubuntu-test-cases/sample-adt-test
Merge into: lp://qastaging/ubuntu-test-cases/touch
Diff against target: 774 lines (+740/-0)
5 files modified
tests/ubuntu-sample-adt-test/COPYING (+674/-0)
tests/ubuntu-sample-adt-test/README.md (+41/-0)
tests/ubuntu-sample-adt-test/debian/changelog (+5/-0)
tests/ubuntu-sample-adt-test/debian/tests/control (+1/-0)
tests/ubuntu-sample-adt-test/debian/tests/sample (+19/-0)
To merge this branch: bzr merge lp://qastaging/~canonical-platform-qa/ubuntu-test-cases/sample-adt-test
Reviewer Review Type Date Requested Status
Paul Larson Approve
Francis Ginther Approve
Christopher Lee Pending
Allan LeSage Pending
Review via email: mp+241321@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-11-06.

Commit message

Added a simple adt-run test to use a sample meeting the CI handoff criteria.

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

This should probably be merged into lp:ubuntu-test-cases/sample-adt-test, which doesn't exist yet. I'm making the MP here in the meantime to make it visible for CI and QA.

Revision history for this message
Allan LeSage (allanlesage) wrote : Posted in a previous version of this proposal

Ok no objection, seems like a pretty simple test, on comment in-line. I'll not 'approve' this as it's not intended for the landing branch, correct?

review: Needs Information
Revision history for this message
Christopher Lee (veebers) wrote : Posted in a previous version of this proposal

Looks good Leo, just one minor spelling thing but otherwise looks really good thanks.

review: Needs Fixing
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

Thanks for the reviews. I think it would be nice to keep this as an independent branch, so we can copy it as the most simple way to start a new test. But I'll ask the CI team for a review and recommendation. I can put it in ubuntu-test-cases/touch.

Revision history for this message
Christopher Lee (veebers) wrote : Posted in a previous version of this proposal

Sweet, looks good.

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote : Posted in a previous version of this proposal

Leo,

I'm not sure this came across in the earlier discussions. The short term goal is to have each directory under /tests/ be a self contained debian project suitable for running the dep8 tests using the adt unbuilt branch mode. So, the file layout might be something like:

lp:ubuntu-test-cases/touch:
 - tests
   - foo-test
     - debian
       - changelog
       - control
       - tests
         - control
       - ...
   - bar-test
     - debian
       - changelog
       - control
       - tests
         - control
       - ...
   - ubuntu-sample-adt-test
     - debian
       - changelog
       - control
       - tests
         - control
       - ...
   - ...

The idea is that the tests can also live as independent debian projects.

review: Needs Fixing
lp://qastaging/~canonical-platform-qa/ubuntu-test-cases/sample-adt-test updated
13. By Leo Arias

Added new line.

Revision history for this message
Leo Arias (elopio) wrote :

1 === renamed file 'README-cli.rst' => 'README-cli.rst'
2 === renamed directory 'jenkins' => 'jenkins'
3 === renamed directory 'scripts' => 'scripts'
4 === renamed directory 'selftests' => 'selftests'
5 === renamed directory 'tests' => 'tests'

I think this is because I started from an independent branch, so it seems to drive launchpad crazy. But also seems harmless.

Revision history for this message
Paul Larson (pwlars) wrote :

A few minor comments, I'm still not sure I understand having it there in this branch, but I'm not necessarily opposed to it.

review: Needs Information
Revision history for this message
Leo Arias (elopio) wrote :

The monitoring is work in progress in this branch:

https://code.launchpad.net/~canonical-platform-qa/uci-engine/nfss-check/+merge/241322

lp://qastaging/~canonical-platform-qa/ubuntu-test-cases/sample-adt-test updated
14. By Leo Arias

Updated the project path.

15. By Leo Arias

Removed the debian/copyright. Added -B to the adt-run command on the readme.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Just a little comment.

Revision history for this message
Leo Arias (elopio) wrote :

> A few minor comments, I'm still not sure I understand having it there in this
> branch, but I'm not necessarily opposed to it.

Thanks for the review Paul. I've made the changes.

About why to have this here, we spent quite some time learning adt-run, the dep8 format, the nfss file and how to make them meet the CI criteria in the simplest way possible. What we learned is summarized on this branch. It's really simple, but if you are new to all this, the sample shows what is required.
In addition, it would be awesome if you guys can put this test to run, to send data to staging NFSS and to be monitored. That way we will know that our testing story works end-to-end, and if we need to update something, this simple project will make it obvious.
This part is just a suggestion of something nice to have. If you don't agree, we can just keep it here but not running, or on an independent branch linked from the documentation, with the risk of it getting outdated.

lp://qastaging/~canonical-platform-qa/ubuntu-test-cases/sample-adt-test updated
16. By Leo Arias

Simplify the run doc.

Revision history for this message
Leo Arias (elopio) :
Revision history for this message
Francis Ginther (fginther) wrote :

I think this is a reasonable sample test and starting point for the nfss and monitoring integration.

review: Approve
Revision history for this message
Paul Larson (pwlars) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches