webbrowser-app

Merge lp://qastaging/~canonical-platform-qa/webbrowser-app/add-timeout-as-param-wait-until-page-loaded into lp://qastaging/webbrowser-app

  1. add-timeout-as-param-wait-until-page-loaded
  2. Merge into trunk
Proposed by Allan LeSage
Status: Needs review
Proposed branch: lp://qastaging/~canonical-platform-qa/webbrowser-app/add-timeout-as-param-wait-until-page-loaded
Merge into: lp://qastaging/webbrowser-app
Diff against target: 17 lines (+2/-2)
1 file modified
tests/autopilot/webbrowser_app/emulators/browser.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~canonical-platform-qa/webbrowser-app/add-timeout-as-param-wait-until-page-loaded
Reviewer Review Type Date Requested Status
Olivier Tilloy Needs Information
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+277743@code.qastaging.launchpad.net

Description of the change

Teensy change to enable those of us with flaky internet connections to control the wait timeout for a page to load.

No special rush on this but for whatever reason I'm having difficulty loading http://www.ubuntu.com to 100% today, a test IMO could wait as long as necessary (defaults to original 20s).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1271
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2476/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5211/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1230
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1230
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1230/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1230
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4141/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5228
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5228/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25184

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2476/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Olivier Tilloy (osomon) wrote :

I don’t mind accepting that change, but I’d like to question the use of external resources in tests: can’t we use an internal HTTP server (like we do in the webbrowser_app and webapp_container autopilot test suites), to avoid relying on the internet connection?

review: Needs Information
Reply

Unmerged revisions

1271. By Allan LeSage

Autopilot: add timeout as param for wait_until_page_loaded.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: