Merge lp://qastaging/~carla-sella/ubuntu-calendar-app/dayview-test-default-view into lp://qastaging/ubuntu-calendar-app

Still need to verify that the day should be scrolled to the current time.

Should be ok now.

FAILED: Continuous integration, rev:607
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1109/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2392/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/580/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/106/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1109/rebuild

FAILED: Continuous integration, rev:608
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1110/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2393
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2393/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/581
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/107

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1110/rebuild

Reported bug #1435542 as in Italy Sunday is the first day of the week and yesterday, 22nd March the week number was 12 and not 11, so this test failed, but should not have:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/calendar_app/tests/test_dayview.py", line 77, in test_default_view
    self.day_view.get_weeknumer(today).text, 'W' + now.strftime("%U"))
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 338, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 423, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 'W11' != 'W12'

I found out why the test is failing only on Sundays.
If you look at the screenshot:

https://dl.dropboxusercontent.com/u/10083981/Ubuntu%20phone/Calendar.png

You can see how the days in Calendar app are displayed, Sunday is together with Saturday and Friday on the same page where there is the W13 week number label, but friday and saturday are W13 while sunday is W14.
That means that, for instance sunday 5 april is displayed on W13 but is
W14 instead.
So the test fails if you are testing on sunday 5 april because I am checking day label and day of week label are correct, the label is correct for two day but not for the third only in pages displaying Friday, Saturday and Sunday together.

So the question is: what should I do if the day I am testing on is a Sunday, this test will always fail on Sundays as Sundays are already on a next week number-

I can verify that if the day I am testing on is a Sunday I have to subtact 1 to week number, but not sure this is what you want me to do.

Carla

FAILED: Continuous integration, rev:609
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1125/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2495
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2495/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/596
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/122

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1125/rebuild

> I found out why the test is failing only on Sundays.
> If you look at the screenshot:
>
> https://dl.dropboxusercontent.com/u/10083981/Ubuntu%20phone/Calendar.png
>
> You can see how the days in Calendar app are displayed, Sunday is together
> with Saturday and Friday on the same page where there is the W13 week number
> label, but friday and saturday are W13 while sunday is W14.
> That means that, for instance sunday 5 april is displayed on W13 but is
> W14 instead.
> So the test fails if you are testing on sunday 5 april because I am checking
> day label and day of week label are correct, the label is correct for two day
> but not for the third only in pages displaying Friday, Saturday and Sunday
> together.
>
> So the question is: what should I do if the day I am testing on is a Sunday,
> this test will always fail on Sundays as Sundays are already on a next week
> number-
>
> I can verify that if the day I am testing on is a Sunday I have to subtact 1
> to week number, but not sure this is what you want me to do.
>
> Carla

Hello Carla,

There seem some issue with logic how we calculate week numer from date.

Date.prototype.weekNumber = function() {
    var date = this.weekStart(1).addDays(3) // Thursday midnight

This is function used, in dateext.js, and looks like week's start day here is hard coded.
I gave you a branch where I resolved this issue, that patch calculate week number by taking in account what is week start day.

Please check with that branch as well.

Hello Kunal,
I merged your branch into mine. It works if I run this test on a Sunday (for instance Sun 5th April), but fails if I run it on the 31st of March for instance, I get this errror:

Traceback (most recent call last):
  File "/home/letozaf/autopilot-tests/dayview-test-default-view/tests/autopilot/calendar_app/tests/test_dayview.py", line 77, in test_default_view
    self.day_view.get_weeknumer(today).text, 'W' + now.strftime("%U"))
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 338, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 423, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 'W14' != 'W13'

> Hello Kunal,
> I merged your branch into mine. It works if I run this test on a Sunday (for
> instance Sun 5th April), but fails if I run it on the 31st of March for
> instance, I get this errror:
>
> Traceback (most recent call last):
> File "/home/letozaf/autopilot-tests/dayview-test-default-
> view/tests/autopilot/calendar_app/tests/test_dayview.py", line 77, in
> test_default_view
> self.day_view.get_weeknumer(today).text, 'W' + now.strftime("%U"))
> File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 338, in
> assertEqual
> self.assertThat(observed, matcher, message)
> File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 423, in
> assertThat
> raise mismatch_error
> testtools.matchers._impl.MismatchError: 'W14' != 'W13'

Hello Carla,

I read python strftime doc. As per it, week start from 00 and end at 53. As per our implementation it start from 1 and end at 54.

Also we need to check what is locale set as per that we should use %U or %W.
I referred this link https://docs.python.org/2/library/time.html

To me looks like using %W instead of %U fixes the issue, but I am not sure. Maybe someone can double check ?

PASSED: Continuous integration, rev:610
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1135/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2519
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2519/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-ci/606
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/132

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1135/rebuild

%W can work, so long as we assume a Monday as first day of the week locale.