Merge lp://qastaging/~cbjchen/charms/trusty/cinder/remove_stale_key into lp://qastaging/~openstack-charmers-archive/charms/trusty/cinder/next

Proposed by Liang Chen
Status: Merged
Merged at revision: 72
Proposed branch: lp://qastaging/~cbjchen/charms/trusty/cinder/remove_stale_key
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/cinder/next
Diff against target: 60 lines (+16/-2)
2 files modified
hooks/cinder_hooks.py (+8/-1)
unit_tests/test_cinder_hooks.py (+8/-1)
To merge this branch: bzr merge lp://qastaging/~cbjchen/charms/trusty/cinder/remove_stale_key
Reviewer Review Type Date Requested Status
Edward Hope-Morley Approve
Review via email: mp+248666@code.qastaging.launchpad.net

Description of the change

Clean up the keyring for cinder after ceph service is destroyed and re-created like below,

1. break relation
2. destroy service
3. deploy new ceph service
4. add relation back

If old key exists, ensure_ceph_keyring will not store the newly retrieved key from ceph.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #1721 cinder-next for cbjchen mp248666
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/1721/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #1549 cinder-next for cbjchen mp248666
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/1549/

Revision history for this message
Edward Hope-Morley (hopem) wrote :

I've deployed this along with the other ceph client changes and it all seems good. Thanks Liang. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches