Mir

Merge lp://qastaging/~cemil-azizoglu/mir/drm-common into lp://qastaging/mir

  1. drm-common
  2. Merge into development-branch
Proposed by Cemil Azizoglu
Status: Work in progress
Proposed branch: lp://qastaging/~cemil-azizoglu/mir/drm-common
Merge into: lp://qastaging/mir
Diff against target: 15 lines (+2/-1)
1 file modified
CMakeLists.txt (+2/-1)
To merge this branch: bzr merge lp://qastaging/~cemil-azizoglu/mir/drm-common
Reviewer Review Type Date Requested Status
Alexandros Frantzis (community) Needs Fixing
Mir CI Bot continuous-integration Approve
Review via email: mp+297794@code.qastaging.launchpad.net

Commit message

Fix an FTBFS during cross-compilation when platform=android.

Description of the change

Fix an FTBFS during cross-compilation when platform=android.

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:3548
https://mir-jenkins.ubuntu.com/job/mir-ci/1166/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/1313
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/1363
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1354
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1354
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/1325
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/1325/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/1325
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/1325/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1325
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1325/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1325
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1325/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/1325
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/1325/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1166/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> DRM is needed for all platforms now.

That's not right, Android doesn't really need drm/kms. It's only needed by the build because parts of our common test code, which Android doesn't use, depend on it. I think the right solution is to split out the parts of the common code that use drm/kms into their own a server-platform-common-kms static library, and change mesa and eglstream to depend on it.

review: Needs Fixing
Reply
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Lower priority. I'll table it for now.

Reply

Unmerged revisions

3548. By Cemil Azizoglu

DRM is needed for all platforms now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches