Unity System Compositor

Merge lp://qastaging/~cemil-azizoglu/unity-system-compositor/address-deprecations into lp://qastaging/unity-system-compositor

  1. address-deprecations
  2. Merge into trunk
Proposed by Cemil Azizoglu
Status: Merged
Approved by: Cemil Azizoglu
Approved revision: 306
Merged at revision: 305
Proposed branch: lp://qastaging/~cemil-azizoglu/unity-system-compositor/address-deprecations
Merge into: lp://qastaging/unity-system-compositor
Diff against target: 119 lines (+35/-28)
3 files modified
spinner/eglapp.cpp (+33/-28)
tests/unit-tests/test_mir_input_configuration.cpp (+1/-0)
tests/unit-tests/test_session_switcher.cpp (+1/-0)
To merge this branch: bzr merge lp://qastaging/~cemil-azizoglu/unity-system-compositor/address-deprecations
Reviewer Review Type Date Requested Status
Mir CI Bot continuous-integration Approve
Brandon Schaefer (community) Approve
Review via email: mp+315170@code.qastaging.launchpad.net

Commit message

Address deprecations in mir.

Description of the change

Address deprecations in mir.

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:305
https://mir-jenkins.ubuntu.com/job/usc-ci/46/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-usc/66/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3721
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3711
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3711
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3711
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=xenial+overlay/70/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=zesty/70/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=armhf,release=vivid+overlay/70/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=xenial+overlay/70/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=zesty/70/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/usc-ci/46/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM, small nits in diff comments

review: Approve
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

> FAILED: Continuous integration, rev:305
> https://mir-jenkins.ubuntu.com/job/usc-ci/46/
> Executed test runs:
> FAILURE: https://mir-jenkins.ubuntu.com/job/build-usc/66/console
> SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3721
> SUCCESS: https://mir-
> jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3711
> SUCCESS: https://mir-
> jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3711
> SUCCESS: https://mir-
> jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3711
> FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-
> usc/arch=amd64,release=xenial+overlay/70/console
> FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-
> usc/arch=amd64,release=zesty/70/console
> FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-
> usc/arch=armhf,release=vivid+overlay/70/console
> FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-
> usc/arch=i386,release=xenial+overlay/70/console
> FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-
> usc/arch=i386,release=zesty/70/console
>
> Click here to trigger a rebuild:
> https://mir-jenkins.ubuntu.com/job/usc-ci/46/rebuild

Looks like the mir changes have not hit the staging yet (r3959 vs needed r3963)

20:11:33 Get:45 http://ppa.launchpad.net/mir-team/staging/ubuntu xenial/main amd64 libmirserver43 amd64 0.26.0+r3959~daily1~ubuntu16.04.1 [442 kB]

lp://qastaging/~cemil-azizoglu/unity-system-compositor/address-deprecations updated
306. By Cemil Azizoglu

Remove consts

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:306
https://mir-jenkins.ubuntu.com/job/usc-ci/47/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-usc/67/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3723
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3713
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3713
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3713
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=xenial+overlay/71/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=zesty/71/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=armhf,release=vivid+overlay/71/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=xenial+overlay/71/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=zesty/71/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/usc-ci/47/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Now the build should be fine.

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:306
https://mir-jenkins.ubuntu.com/job/usc-ci/48/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-usc/68
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3729
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3719
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3719
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3719
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=xenial+overlay/72
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=xenial+overlay/72/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=zesty/72
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=zesty/72/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=armhf,release=vivid+overlay/72
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=armhf,release=vivid+overlay/72/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=xenial+overlay/72
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=xenial+overlay/72/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=zesty/72
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=zesty/72/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/usc-ci/48/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches