Merge lp://qastaging/~cfebs/terminator/terminator-add-ctrl-zoom-pref into lp://qastaging/terminator/gtk3
Proposed by
Collin Lefeber
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~cfebs/terminator/terminator-add-ctrl-zoom-pref |
| Merge into: | lp://qastaging/terminator/gtk3 |
| Diff against target: |
134 lines (+43/-13) 4 files modified
terminatorlib/config.py (+1/-0) terminatorlib/preferences.glade (+18/-0) terminatorlib/prefseditor.py (+13/-5) terminatorlib/terminal.py (+11/-8) |
| To merge this branch: | bzr merge lp://qastaging/~cfebs/terminator/terminator-add-ctrl-zoom-pref |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Bryce Harrington | code review | Approve | |
|
Review via email:
|
|||
Commit message
Adds preference to toggle Ctrl+Scroll zoom feature
Description of the change
Controlling zoom in/out with Ctrl and Touchpad/Mouse zoom can be tricky with a very sensitive touch pad.
This PR adds an option (enabled by default to match current behavior) that allows users to disable this feature if they desire.
The option in the UI is called "Enable Ctrl Scroll Zoom"
Related issues:
- https:/
- https:/
- https:/
To post a comment you must log in.
Unmerged revisions
- 1814. By Collin Lefeber
-
Add ctrl zoom scroll preference
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Conceptually and implementationally LGTM. The patch appears to include some whitespace changes but I don't think those should inhibit inclusion of this patch.
I haven't hit this particular problem however I've accidentally zoomed via inadvertent <ctrl>+<shift>+<+>. Having things zoom accidentally is indeed a bit irritating, so ensuring ways of controlling it will give user's better control.