Landscape Client

Merge lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-activeprocess into lp://qastaging/~landscape/landscape-client/trunk

  1. mocker-to-mock-activeprocess
  2. Merge into trunk
Proposed by Chad Smith
Status: Merged
Approved by: Chad Smith
Approved revision: 863
Merged at revision: 869
Proposed branch: lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-activeprocess
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 34 lines (+5/-5)
1 file modified
landscape/monitor/tests/test_activeprocessinfo.py (+5/-5)
To merge this branch: bzr merge lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-activeprocess
Reviewer Review Type Date Requested Status
🤖 Landscape Builder test results Approve
Adam Collard (community) Approve
Simon Poirier (community) Approve
Review via email: mp+297543@code.qastaging.launchpad.net

Commit message

Mocker to mock activeprocess unit tests.

Description of the change

Mocker to mock activeprocess unit tests.

To post a comment you must log in.
Revision history for this message
Simon Poirier (simpoir) wrote :

+1 with an inline suggestion.

review: Approve
Revision history for this message
Adam Collard (adam-collard) wrote :

+1 assuming the revert of the changes to the test_processorinfo

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make check
Result: Success
Revno: 861
Branch: lp:~chad.smith/landscape-client/mocker-to-mock-activeprocess
Jenkins: https://ci.lscape.net/job/latch-test/5059/

review: Approve (test results)
lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-activeprocess updated
862. By Chad Smith

use return_value in Mock init as side_effect hacking is unnecessary for a single call

863. By Chad Smith

lint fix

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: