Merge lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-package-reporter-2 into lp://qastaging/~landscape/landscape-client/trunk
Proposed by
Chad Smith
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Chad Smith | ||||
| Approved revision: | 896 | ||||
| Merged at revision: | 907 | ||||
| Proposed branch: | lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-package-reporter-2 | ||||
| Merge into: | lp://qastaging/~landscape/landscape-client/trunk | ||||
| Diff against target: |
252 lines (+56/-70) 1 file modified
landscape/package/tests/test_reporter.py (+56/-70) |
||||
| To merge this branch: | bzr merge lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-package-reporter-2 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alberto Donato (community) | Approve | ||
| Chris Glass (community) | Approve | ||
| Geoff Teale (community) | Approve | ||
| 🤖 Landscape Builder | test results | Approve | |
|
Review via email:
|
|||
Commit message
Time to retire mocker, you have lived a good life.
Phase 2 test_reporter mocker-> mock
Description of the change
Time to retire mocker, you have lived a good life.
Phase 2 test_reporter mocker-> mock
Testing instructions:
trial landscape.
To post a comment you must log in.
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) | # |
review:
Abstain
(executing tests)
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) wrote | # |
review:
Approve
(test results)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 896
Branch: lp:~chad.smith/landscape-client/mocker-to-mock-package-reporter-2
Jenkins: https:/