Landscape Client

Merge lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-package-reporter into lp://qastaging/~landscape/landscape-client/trunk

  1. mocker-to-mock-package-reporter
  2. Merge into trunk
Proposed by Chad Smith
Status: Merged
Approved by: Chad Smith
Approved revision: 885
Merged at revision: 896
Proposed branch: lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-package-reporter
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 214 lines (+37/-54)
1 file modified
landscape/package/tests/test_reporter.py (+37/-54)
To merge this branch: bzr merge lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-package-reporter
Reviewer Review Type Date Requested Status
🤖 Landscape Builder test results Approve
Chris Glass (community) Approve
Adam Collard (community) Approve
Review via email: mp+297647@code.qastaging.launchpad.net

Commit message

Phase 1, replace basic logging mocker w/ mock patches.

This file has significant mocker use. It is separated into parts to aid reviews.

Description of the change

Phase 1, replace basic logging mocker w/ mock patches.

This file has significant mocker use. It is separated into parts to aid reviews.

Testing instructions:
trial landscape.package.tests.test_reporter

To post a comment you must log in.
Revision history for this message
Adam Collard (adam-collard) wrote :

some nits, +1

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Fail
Revno: 884
Branch: lp:~chad.smith/landscape-client/mocker-to-mock-package-reporter
Jenkins: https://ci.lscape.net/job/latch-test/5092/

review: Needs Fixing (test results)
lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-package-reporter updated
885. By Chad Smith

address sparkiegeek's review: isn't it ironic ...

Revision history for this message
Chad Smith (chad.smith) :
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
Chris Glass (tribaal) wrote :

+1

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 885
Branch: lp:~chad.smith/landscape-client/mocker-to-mock-package-reporter
Jenkins: https://ci.lscape.net/job/latch-test/5098/

review: Approve (test results)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: