Landscape Client

Merge lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-processkiller into lp://qastaging/~landscape/landscape-client/trunk

  1. mocker-to-mock-processkiller
  2. Merge into trunk
Proposed by Chad Smith
Status: Merged
Approved by: David Britton
Approved revision: 875
Merged at revision: 883
Proposed branch: lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-processkiller
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 58 lines (+7/-9)
1 file modified
landscape/manager/tests/test_processkiller.py (+7/-9)
To merge this branch: bzr merge lp://qastaging/~chad.smith/landscape-client/mocker-to-mock-processkiller
Reviewer Review Type Date Requested Status
Chris Glass (community) Approve
🤖 Landscape Builder test results Approve
Bogdana Vereha (community) Approve
Review via email: mp+297573@code.qastaging.launchpad.net

Commit message

Move away from mocker and use python mock for processkiller unit tests.

Description of the change

Move away from mocker and use python mock for processkiller unit tests.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
Bogdana Vereha (bogdana) wrote :

+1

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 875
Branch: lp:~chad.smith/landscape-client/mocker-to-mock-processkiller
Jenkins: https://ci.lscape.net/job/latch-test/5071/

review: Approve (test results)
Revision history for this message
Chris Glass (tribaal) wrote :

+1

DO IT! Merge the killer!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: