Merge lp://qastaging/~chad.smith/lp2kanban/allow-mps-linked-to-branch-cards into lp://qastaging/lp2kanban

Proposed by Chad Smith
Status: Merged
Approved by: Chad Smith
Approved revision: 130
Merged at revision: 128
Proposed branch: lp://qastaging/~chad.smith/lp2kanban/allow-mps-linked-to-branch-cards
Merge into: lp://qastaging/lp2kanban
Diff against target: 151 lines (+39/-14)
3 files modified
src/lp2kanban/bugs2cards.py (+22/-8)
src/lp2kanban/kanban.py (+8/-4)
src/lp2kanban/tests/test_bugs2cards.py (+9/-2)
To merge this branch: bzr merge lp://qastaging/~chad.smith/lp2kanban/allow-mps-linked-to-branch-cards
Reviewer Review Type Date Requested Status
Benji York (community) Approve
Review via email: mp+282684@code.qastaging.launchpad.net

Commit message

Support branch cards that contain either a launchapad MP url or branch url. Emit warnings for cards that link to non-branch/MP urls.

Description of the change

Update regex to match both MP and branch url to kanban.

Add get_lp_branch_name to extract a valid branch url from either MP or branch links provided in card.external_system_url.

Also emit warnings if external_system_url isn't set to a launchpad branch or mp url so we can track down automation issues from jenkins output.

To test:

https://ci.lscape.net/view/Infrastructure/job/kanban-sync/configure
# change the repository URL from lp:lp2kanban to lp:~chad.smith/lp2kanban/allow-mps-linked-to-branch-cards

Then click build.
It'll run against our board
You can watch the "Activity Stream" accessible from the Pie chart icon on the right side of our board (https://canonical.leankit.com/Boards/View/102392996#workflow-view)

Any changes made by kanban-sync will be labelled as performed by "Landscape Robot"

Alternately you can run biuldout locally to setup a local python environment in ./bin/py
make configs
./create_creds.py (then authorize your user for everything in the browser that starts)
./bin/py -c configs/sync.ini -b "Lanscape 2016"

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

This branch looks good.

review: Approve
131. By Chad Smith

use raw string for REGEX per review comment

Revision history for this message
Chad Smith (chad.smith) :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: