Merge lp://qastaging/~chad.smith/lp2kanban/feature-card-consolidation-in-landed-lane into lp://qastaging/lp2kanban
Proposed by
Chad Smith
| Status: | Merged |
|---|---|
| Merged at revision: | 130 |
| Proposed branch: | lp://qastaging/~chad.smith/lp2kanban/feature-card-consolidation-in-landed-lane |
| Merge into: | lp://qastaging/lp2kanban |
| Diff against target: |
220 lines (+132/-8) 3 files modified
src/lp2kanban/bugs2cards.py (+13/-7) src/lp2kanban/tests/common.py (+9/-1) src/lp2kanban/tests/test_bugs2cards.py (+110/-0) |
| To merge this branch: | bzr merge lp://qastaging/~chad.smith/lp2kanban/feature-card-consolidation-in-landed-lane |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Free Ekanayaka (community) | Approve | ||
| Данило Шеган (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Add logic to trigger feature flag taskboard consolidation when Feature cards are dragged into either deploy_lanes or landing_lanes.
Also add logic to support landing_lanes configurations that do not specify ${group} template.
Ran this as a live jenkins job successfully against our board.
To run local unit tests:
# depending on your release you may need to tweak buildout.cfg dropping a couple of conflicts to allow buildout to complete
make
./bin/test
Additional testing alternative:
specify a different repository url in https:/
To post a comment you must log in.
Revision history for this message
| Chad Smith (chad.smith) | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for taking this on, Chad. I do have a couple of comments, the bigger one being in the tests infrastructure. Since the functionality is not affected, approving, but please address the issues I raise.
(FWIW, for the benefit of other reviews: I found it easiest to temporarily remove python-zc.buildout package on my Wily installation to get make and make check to work.)