Merge lp://qastaging/~chad.smith/lp2kanban/merge-kanban-cross-team-fixes into lp://qastaging/lp2kanban

Proposed by Chad Smith
Status: Merged
Merged at revision: 136
Proposed branch: lp://qastaging/~chad.smith/lp2kanban/merge-kanban-cross-team-fixes
Merge into: lp://qastaging/lp2kanban
Prerequisite: lp://qastaging/~chad.smith/lp2kanban/multitask-multibranch-bugs
Diff against target: 491 lines (+164/-91) (has conflicts)
5 files modified
Makefile (+57/-0)
run.sh (+0/-21)
setup.py (+1/-0)
src/lp2kanban/bugs2cards.py (+41/-25)
src/lp2kanban/tests/test_bugs2cards.py (+65/-45)
Conflict adding file Makefile.  Moved existing file to Makefile.moved.
To merge this branch: bzr merge lp://qastaging/~chad.smith/lp2kanban/merge-kanban-cross-team-fixes
Reviewer Review Type Date Requested Status
Данило Шеган (community) Approve
Benji York (community) Approve
Review via email: mp+291414@code.qastaging.launchpad.net

Description of the change

The cross-team jenkins job (https://ci.lscape.net/job/kanban-cross-team/) is already running on lp:lp2kanban and it relies on configuration files maas.ini, juju.ini, charms.ini and server.ini which are already added to our lp:~landscape/landscape/lp2kanban-configs repo.

There are some missing config option changes needed to support those ini files which David originally made to the lp2kanban fork at lp:~landscape/lp2kanban/cross-team.

This cross team changes add the following support for configuration options:

**new_lanes**: the lane(s) into which cards at "New", "Confirmed" "Triaged" or "Incomplete"
                    bug statuses are moved
**done_lanes**: DROPPED in favor of the more granular done_fix_lanes and done_nofix_lanes

**done_fix_lanes**: the lane(s) into which bugs in "Fix Released" status are moved

**done_nofix_lanes**: the lane(s) into which bugs in "Opinion", "Invalid", "Won't Fix", "Expired"
                    bug statuses are move

This branch also changes lp2kanban to rename todo_lane to new_lane as they have the same intended behavior.

To support testing this branch, rev 9 of lp:~landscape/landscape/lp2kanban-configs adds these new lane config options to our kanban-sync's "sync.ini" file so existing lp2kanban can continue to use the old todo_lane and done_lane.

Unit tests were added to cover the changes to better describe and test new behavior.

To test:

# Either make this project
make configs
make credentials
make
make check
./bin/py ./src/lp2kanban/bugs2cards.py -c configs/sync.ini -b "Landscape 2016"

# Or Hijack jenkins kanban sync job and point the Repository URL to lp:~chad.smith/lp2kanban/merge-kanban-cross-team-fixes instead of lp:lp2kanban

https://ci.lscape.net/job/kanban-sync/configure

# Or stop the jenkins kanban-sync job and patch the existing checkout (which is refreshed each run anyway)
ssh <email address hidden>; sudo -u jenkins bash; cd /var/lib/jenkins/workspaces/kanban-sync; bzr merge lp:~chad.smith/lp2kanban/merge-kanban-cross-team-fixes; ./bin/py -c configs/sync.ini -b "Landscape 2016"

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

This branch looks good.

review: Approve
Revision history for this message
Данило Шеган (danilo) wrote :

Looks good, thanks!

Make sure it still works with cross-team job, too :)

review: Approve
142. By Chad Smith

drop unused run.sh

143. By Chad Smith

revert Makefile change

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: