Unity HUD

Merge lp://qastaging/~charlesk/hud/lp-1243654 into lp://qastaging/hud/13.10

  1. lp-1243654
  2. Merge into trunk.13.10
Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 342
Merged at revision: 344
Proposed branch: lp://qastaging/~charlesk/hud/lp-1243654
Merge into: lp://qastaging/hud/13.10
Diff against target: 43 lines (+15/-10)
1 file modified
window-stack-bridge/BamfWindowStack.cpp (+15/-10)
To merge this branch: bzr merge lp://qastaging/~charlesk/hud/lp-1243654
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ted Gould (community) Approve
Review via email: mp+192923@code.qastaging.launchpad.net

Description of the change

Add a null safeguard when accessing window SharedPtrs held in the m_windows QMap

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:342
http://jenkins.qa.ubuntu.com/job/hud-13.10-ci/3/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-13.10-saucy-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-13.10-saucy-armhf-ci/3
    FAILURE: http://jenkins.qa.ubuntu.com/job/hud-13.10-saucy-i386-ci/3/console

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/hud-13.10-ci/3/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:342
http://jenkins.qa.ubuntu.com/job/hud-13.10-ci/4/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-13.10-saucy-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-13.10-saucy-armhf-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-13.10-saucy-i386-ci/4

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/hud-13.10-ci/4/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches