Indicator Display Objects

Merge lp://qastaging/~charlesk/ido/lp-906050 into lp://qastaging/ido/0.3

lp-906050
Merge into trunk

Proposed by Charles Kerr on 2012-03-10

Status:

Merged

Approved by:

Charles Kerr on 2012-03-12

Approved revision:

104

Merge reported by:

Charles Kerr

Merged at revision:

not available

Proposed branch:

lp://qastaging/~charlesk/ido/lp-906050

Merge into:

lp://qastaging/ido/0.3

Diff against target:

832 lines (+20/-695)

4 files modified

src/Makefile.am (+0/-15)
src/idooffscreenproxy.c (+0/-515)
src/idooffscreenproxy.h (+0/-62)
src/idoscalemenuitem.c (+20/-103)

To merge this branch:

bzr merge lp://qastaging/~charlesk/ido/lp-906050

Related bugs:

Bug #524541: Volume (slider) item isn't highlighted when selected	Medium	Fix Released
Bug #874431: All indicators crash when I click on sound indicator	Undecided	Fix Released
Bug #886335: Unable to use arrow keys to adjust the volume control in the sound menu.	High	Fix Released
Bug #906050: Playback controls don't highlight anything like other menu items	Medium	Invalid
Bug #945558: sound indicator renders incorrect when switching fast between indicators	High	Fix Released

Link a bug report

Reviewer	Date Requested	Status
Conor Curran (community)	2012-03-10	Approve on 2012-03-12
Indicator Applet Developers	2012-03-10	Pending
Review via email: mp+96859@code.qastaging.launchpad.net

Description of the change

Fix LP Bug #906050 by removing idoscalemenuitem's offscreen proxy.

NOTE TO REVIEWERS, please read before reviewing:

The offscreen proxy was added last September to fix bug #804009, but while testing in 12.04b1 I'm not able to reproduce that issue even after removing the offscreen proxy. This patch removes the offscreen proxy, and since I don't want to regress 804009 I would like more eyeballs on this one.

To test for a bug #804009 regression, try running indicator-sound with this branch's version of IDO, then test for 804009's behavior: "with the latest update of indicator sound, when you click on the volume slider to change the volumes, the SoundMenu closes and you have to open it again." and "It closes when the user clicks on the slider, then when it is reopened, the slider follow the mouse, then if you click on the slider again it selects the slider with a translucid orange area."

Revision history for this message

Conor Curran (cjcurran) on 2012-03-12:

review: Approve

Revision history for this message

Conor Curran (cjcurran) wrote on 2012-03-12:

Looking good ! Finally a maintainer for our libido ;-)

Revision history for this message

Sebastien Bacher (seb128) wrote on 2012-03-12:

It works fine for me but I don't know enough of the reason why the offscreen logic was added to start so I'm a bit nervous acking it being dropped, I figure it wouldn't have been added if it was not needed for a reason, I would prefer to have somebody who has a clue about the historical reason to ack it