Merge lp://qastaging/~charlesk/indicator-appmenu/lp-1244250 into lp://qastaging/indicator-appmenu/14.04

Proposed by Charles Kerr
Status: Merged
Approved by: Charles Kerr
Approved revision: 248
Merged at revision: 248
Proposed branch: lp://qastaging/~charlesk/indicator-appmenu/lp-1244250
Merge into: lp://qastaging/indicator-appmenu/14.04
Diff against target: 135 lines (+11/-46)
1 file modified
src/indicator-appmenu.c (+11/-46)
To merge this branch: bzr merge lp://qastaging/~charlesk/indicator-appmenu/lp-1244250
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Lars Karlitski (community) Approve
Review via email: mp+192525@code.qastaging.launchpad.net

Description of the change

If we can't get the bus, exit instead of stacking g_bus_own_name() calls on top of each other, leaking GSources.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Lars Karlitski (larsu) wrote :

The CI issue is fixed on r248 in lp:~larsu/indicator-appmenu/destroy-widget. Let's rebase this branch after that other one lands.

Looks good to me otherwise. Thanks!

review: Approve
248. By Charles Kerr

sync with trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

Top-approving based off Lars' and Jenkins' approval

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches