lp://qastaging/~charlesk/indicator-appmenu/lp-1294545

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://qastaging/indicator-appmenu/14.04 at revision 257

PS Jenkins bot (community): Approve (continuous-integration) on 2014-03-19

Ted Gould (community): Approve on 2014-03-19

Diff: 135 lines (+23/-26)

2 files modified

src/indicator-appmenu.c (+9/-26)
src/window-menu.c (+14/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1294545: unity-panel-service crashed with SIGSEGV in window_menu_get_entries()

Medium

Fix Released

Link a bug report

Related blueprints

258. By Charles Kerr on 2014-03-19

ensure we don't unref a WindowMenu before it's been removed from our 'apps' hashtable.

257. By Charles Kerr on 2014-03-19

add input-sanitizing safeguards to WindowMenu's public functions.

256. By PS Jenkins bot on 2014-03-18

Releasing 13.01.0+14.04.20140318-0ubuntu1

255. By Charles Kerr on 2014-03-18

Minor copyediting of schema key's summary/description. Fixes: 970903

254. By Charles Kerr on 2014-03-18

When pruning libtool/static libraries in debian/rules' override_dh_install, use a matching pattern that actually finds the files we want to prune. Fixes: 1281659

253. By Charles Kerr on 2014-02-06

Check for PROP_LABEL to be non-null before passing it a long to gtk_label_set_text_with_mnemonic().

Approved by PS Jenkins bot, Ted Gould.

252. By PS Jenkins bot on 2013-11-25

Releasing 13.01.0+14.04.20131125-0ubuntu1 (revision 251 from lp:indicator-appmenu).

Approved by PS Jenkins bot.

251. By Lars Karlitski on 2013-11-19

WindowMenuModel: insert action groups on the toplevel menus

Inserting them on the menu items was a workaround for the long-fixed cloaking-bug in libindicator. It's not supported in gtk 3.10 anymore, because the menu tracker in gtk doesn't allow action groups on menu items. That's for good reasons: it's more efficient and consumers of that api should not modify the created menu hierarchy.

Approved by PS Jenkins bot, Sebastien Bacher.

250. By Sebastien Bacher on 2013-11-19

Build with -Wno-error=deprecated-declarations.

Approved by PS Jenkins bot, Lars Uebernickel.

249. By Lars Karlitski on 2013-10-28

window-menu-model: disconnect entry signal handlers by func instead of id

entry_object_free disconnected signal handlers by id. This throws warnings when entry_object_free is called when disposing an object, because signals are already disconnected at that point.

This patch uses g_signal_handlers_disconnect_by_func(), which works both when the entry is alive and being disposed.

Approved by Charles Kerr, PS Jenkins bot.