Merge lp://qastaging/~charlesk/indicator-datetime/add-cppcheck into lp://qastaging/indicator-datetime/15.10
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~charlesk/indicator-datetime/add-cppcheck |
| Merge into: | lp://qastaging/indicator-datetime/15.10 |
| Diff against target: |
237 lines (+25/-16) 18 files modified
debian/control (+1/-0) include/datetime/clock.h (+1/-1) include/datetime/timezone-file.h (+1/-1) src/awake.cpp (+1/-1) src/clock.cpp (+1/-1) src/exporter.cpp (+1/-1) src/formatter-desktop.cpp (+1/-1) src/haptic.cpp (+1/-1) src/notifications.cpp (+1/-1) src/planner-aggregate.cpp (+1/-1) src/timezone-geoclue.cpp (+1/-1) src/wakeup-timer-mainloop.cpp (+1/-1) src/wakeup-timer-powerd.cpp (+1/-1) tests/CMakeLists.txt (+8/-0) tests/geoclue-fixture.h (+1/-1) tests/test-dbus-fixture.h (+2/-2) tests/test-timezone-geoclue.cpp (+1/-0) tests/test-timezones.cpp (+0/-1) |
| To merge this branch: | bzr merge lp://qastaging/~charlesk/indicator-datetime/add-cppcheck |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Indicator Applet Developers | Pending | ||
|
Review via email:
|
|||
Commit message
Add a cppcheck pass to the tests run by ctest.
Description of the change
Add a cppcheck pass to the tests run by ctest.
Various minor fixes spotted by cpptest; e.g. adding 'explicit' where applicable to single-argument ctors, removing dead stores
| PS Jenkins bot (ps-jenkins) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
Unmerged revisions
- 426. By Charles Kerr
-
sync with trunk
- 425. By Charles Kerr
-
suppress false pureVirtualCall cppcheck failure. Lambda code blocks in menu's ctor invokes a pure virtual function, but the lambda's not invoked until later after the ctor is finished
- 424. By Charles Kerr
-
fix dead store (cppcheck)
- 423. By Charles Kerr
-
fix unnecesssary c_str() call (cppcheck)
- 422. By Charles Kerr
-
fix dead store due to missing test condition (cppcheck)
- 421. By Charles Kerr
-
in the DBus test fixture, ensure the bus fields are initialized to nullptr when the fixture is constructed. (cppcheck)
- 420. By Charles Kerr
-
fix possible nullptr dereference (cppcheck)
- 419. By Charles Kerr
-
add 'explicit' keyword to single-argument ctors (cppcheck)
- 418. By Charles Kerr
-
add cppcheck to the standard 'make test' invocation
PASSED: Continuous integration, rev:425
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://