Indicator Date and Time

Merge lp://qastaging/~charlesk/indicator-datetime/lp-1306112-query-eds-less-frequently-if-load-is-heavy into lp://qastaging/indicator-datetime/14.04

  1. lp-1306112-query-eds-less-frequently-if-load-is-heavy
  2. Merge into trunk.14.04
Proposed by Charles Kerr
Status: Merged
Approved by: Bill Filler
Approved revision: 344
Merged at revision: 339
Proposed branch: lp://qastaging/~charlesk/indicator-datetime/lp-1306112-query-eds-less-frequently-if-load-is-heavy
Merge into: lp://qastaging/indicator-datetime/14.04
Diff against target: 262 lines (+78/-96)
4 files modified
include/datetime/appointment.h (+0/-2)
src/appointment.cpp (+0/-1)
src/engine-eds.cpp (+78/-91)
tests/manual-test-snap.cpp (+0/-2)
To merge this branch: bzr merge lp://qastaging/~charlesk/indicator-datetime/lp-1306112-query-eds-less-frequently-if-load-is-heavy
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Renato Araujo Oliveira Filho Pending
Review via email: mp+215497@code.qastaging.launchpad.net

Commit message

If there's a large batch of EDS events coming in, try to wait until the event storm has passed before running our requery.

Description of the change

If there's a large batch of EDS events coming in, try to wait until the event storm has passed before running our requery.

Previously we re-queried after an interval of 200 msec. This patch progressively widens that window until the event storm subsides, or until a minute has passed, whichever comes first.

Made in collaboration w/Renato.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:339
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/223/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-trusty-amd64-ci/103
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-trusty-armhf-ci/103
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-trusty-armhf-ci/103/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/223/rebuild

review: Approve (continuous-integration)
lp://qastaging/~charlesk/indicator-datetime/lp-1306112-query-eds-less-frequently-if-load-is-heavy updated
340. By Charles Kerr

remove some extraneous EDS events on startup

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:340
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/224/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-trusty-amd64-ci/104
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-trusty-armhf-ci/104
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-trusty-armhf-ci/104/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/224/rebuild

review: Approve (continuous-integration)
lp://qastaging/~charlesk/indicator-datetime/lp-1306112-query-eds-less-frequently-if-load-is-heavy updated
341. By Charles Kerr

remove unused field Appointment.is_event

342. By Charles Kerr

remove unused field Appointment.is_daily

343. By Charles Kerr

sync with lp:~renatofilho/qtorganizer5-eds/fix-1284375's method of storing alarm urls. Happily this supercedes our code that used to call e_cal_client_get_attachment_uris(), so this means fewer round trip calls to EDS

344. By Charles Kerr

copyediting: fix indentation/formatting

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:343
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/225/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-trusty-amd64-ci/105
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-trusty-armhf-ci/105
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-trusty-armhf-ci/105/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/225/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:344
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/226/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-trusty-amd64-ci/106
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-trusty-armhf-ci/106
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-trusty-armhf-ci/106/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/226/rebuild

review: Approve (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
yes

Did CI run pass? If not, please explain why.
yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches