Indicator Date and Time

Merge lp://qastaging/~charlesk/indicator-datetime/lp-1320880-shorter-notifications-for-calendar-events into lp://qastaging/indicator-datetime/15.04

  1. lp-1320880-shorter-notifications-for-calendar-events
  2. Merge into trunk.15.04
Proposed by Charles Kerr
Status: Merged
Approved by: Charles Kerr
Approved revision: 390
Merged at revision: 391
Proposed branch: lp://qastaging/~charlesk/indicator-datetime/lp-1320880-shorter-notifications-for-calendar-events
Merge into: lp://qastaging/indicator-datetime/15.04
Prerequisite: lp://qastaging/~charlesk/indicator-datetime/lp-1387231-honor-x-canonical-disabled-tag
Diff against target: 67 lines (+19/-4)
2 files modified
src/snap.cpp (+9/-4)
tests/manual (+10/-0)
To merge this branch: bzr merge lp://qastaging/~charlesk/indicator-datetime/lp-1320880-shorter-notifications-for-calendar-events
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+243939@code.qastaging.launchpad.net

Commit message

Change notifications for calendar events s.t. the sound is nonrepeating and the notification is temporary, not requiring user interaction to disappear.

Description of the change

Description of the Change
=========================

This branch culls the bugfix for bug #1320880 from my development branch so that it's easier to review and to backport in isolation.

It's a fairly simple patch: it changes notifications for calendar events s.t. the sound is nonrepeating and the notification is temporary, not requiring user interaction to disappear.

Checklist
=========

> Are there any related MPs required for this MP to build/function as expected? Please list.

This MP stacks on top of lp:~charlesk/indicator-datetime/lp-1387231-honor-x-canonical-disabled-tag

> Is your branch in sync with latest trunk? (e.g. bzr pull lp:trunk -> no changes)

Yes

> Did the code build without warnings?

Yes

> Did the tests run successfully?

Yes

> Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

> If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

N/A

> What device (or emulator) has your component test plan been executed successfully on?

Krillin running ubuntu-touch/ubuntu-rtm/14.09

> What manual tests are relevant for this MP?

indicator-datetime/calendar-event-notification

> Did you include a link to the MR Review Checklist Template to make your reviewer's life easier?

https://wiki.ubuntu.com/Process/Merges/Checklists/indicator-datetime

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:390
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/287/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-vivid-amd64-ci/1/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-vivid-armhf-ci/1
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-vivid-armhf-ci/1/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/287/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

This looks like a jenkins hiccup, but since the ci lab is moving it appears that s-jenkins is unreachable right now. So re-running ci will have to wait a bit.

Revision history for this message
Ted Gould (ted) wrote :

Minor nit. Top approve when ready (either way)

review: Approve
Revision history for this message
Charles Kerr (charlesk) wrote :

Comment added below; top-approving as per Ted's previous comment.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches