Merge lp://qastaging/~charlesk/indicator-datetime/lp-1320880-shorter-notifications-for-calendar-events into lp://qastaging/indicator-datetime/rtm-14.09
| Status: | Approved |
|---|---|
| Approved by: | Ted Gould |
| Approved revision: | 391 |
| Proposed branch: | lp://qastaging/~charlesk/indicator-datetime/lp-1320880-shorter-notifications-for-calendar-events |
| Merge into: | lp://qastaging/indicator-datetime/rtm-14.09 |
| Prerequisite: | lp://qastaging/~charlesk/indicator-datetime/lp-1387231-honor-x-canonical-disabled-tag |
| Diff against target: |
60 lines (+14/-6) 2 files modified
src/snap.cpp (+5/-6) tests/manual (+9/-0) |
| To merge this branch: | bzr merge lp://qastaging/~charlesk/indicator-datetime/lp-1320880-shorter-notifications-for-calendar-events |
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ted Gould (community) | Approve | ||
| Michał Sawicz | ux | Needs Fixing | |
|
Review via email:
|
|||
Commit message
Change notifications for calendar events s.t. the sound is nonrepeating and the notification is temporary, not requiring user interaction to disappear.
Description of the change
Same MP as proposed for Vivid @ https:/
Description of the Change
=======
This branch culls the bugfix for bug #1320880 from my development branch so that it's easier to review and to backport in isolation.
It's a fairly simple patch: it changes notifications for calendar events s.t. the sound is nonrepeating and the notification is temporary, not requiring user interaction to disappear.
Checklist
=========
> Are there any related MPs required for this MP to build/function as expected? Please list.
This MP stacks on top of lp:~charlesk/indicator-datetime/lp-1387231-honor-x-canonical-disabled-tag
> Is your branch in sync with latest trunk? (e.g. bzr pull lp:trunk -> no changes)
Yes
> Did the code build without warnings?
Yes
> Did the tests run successfully?
Yes
> Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
> If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
> What device (or emulator) has your component test plan been executed successfully on?
Krillin running ubuntu-
> What manual tests are relevant for this MP?
indicator-
> Did you include a link to the MR Review Checklist Template to make your reviewer's life easier?
https:/
| Ted Gould (ted) | # |
| Ted Gould (ted) wrote | # |
Unmerged revisions
- 391. By Charles Kerr
-
Make calendar event notifications snap decisions that require manual dismissal, but without looping sound and without haptic feedback. This splits the difference between bug #1320880's complaint "calendar notifications are too intrusive" and bug #1401802's complaint "the new calendar notifications aren't intrusive enough."
I believe these changes need a design review, see bug #1401802.