Merge lp://qastaging/~charlesk/indicator-datetime/lp-1364949-honor-changes-to-alarm-sounds into lp://qastaging/indicator-datetime/13.10
Proposed by
Charles Kerr
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Antti Kaijanmäki | ||||
Approved revision: | 384 | ||||
Merged at revision: | 385 | ||||
Proposed branch: | lp://qastaging/~charlesk/indicator-datetime/lp-1364949-honor-changes-to-alarm-sounds | ||||
Merge into: | lp://qastaging/indicator-datetime/13.10 | ||||
Diff against target: |
35 lines (+14/-0) 2 files modified
src/appointment.cpp (+1/-0) tests/manual (+13/-0) |
||||
To merge this branch: | bzr merge lp://qastaging/~charlesk/indicator-datetime/lp-1364949-honor-changes-to-alarm-sounds | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Antti Kaijanmäki (community) | Approve | ||
Review via email: mp+237474@code.qastaging.launchpad.net |
Commit message
Fix appointment comparison function to include the audio_url field in its test.
Description of the change
1. Fix appointment comparison function to include the audio_url field in its test. Missing this is what prevented the core::Property's changed signals from being emitted -- Appointment's equality operator reported two appointments as the same even when they had different audio_url fields.
2. Added manual test based on Dave Morley's report in bug #1364949
To post a comment you must log in.
LGTM.